Re: pkg/48703: multimedia/libass 0.11.1 libtool --quiet --mode=compile "yasm" unable to infer tagged configuration

[Richard PALO <richard%netbsd.org@localhost>]

The following reply was made to PR pkg/48703; it has been noted by GNATS.

From: Richard PALO <richard%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/48703: multimedia/libass 0.11.1 libtool --quiet --mode=compile
 "yasm" unable to infer tagged configuration
Date: Fri, 29 Aug 2014 17:00:35 +0200

 This is a multi-part message in MIME format.
 --------------010805020209000405080900
 Content-Type: text/plain; charset=UTF-8; format=flowed
 Content-Transfer-Encoding: 8bit
 
 Le 04/04/14 07:15, davshao%gmail.com@localhost a écrit :
 >> Number:         48703
 >> Category:       pkg
 >> Synopsis:       multimedia/libass 0.11.1 libtool --quiet --mode=compile 
 >> "yasm" unable to infer tagged configuration
 >> Confidential:   no
 >> Severity:       non-critical
 >> Priority:       low
 >> Responsible:    pkg-manager
 >> State:          open
 >> Class:          sw-bug
 >> Submitter-Id:   net
 >> Arrival-Date:   Fri Apr 04 05:15:00 +0000 2014
 >> Originator:     David Shao
 >> Release:        NetBSD 6.99.36 amd64
 >> Organization:
 >> Environment:
 > NetBSD  6.99.36 NetBSD 6.99.36 (GENERIC) #1: Tue Mar 11 00:45:13 PDT 2014  
 > xxxxx@:/usr/obj/sys/arch/amd64/compile/GENERIC amd64
 >
 >> Description:
 > For latest cvs pkgsrc on a NetBSD 6.99.36 amd64 X11_TYPE=native system and a 
 > DragonFly 3.7-DEVELOPMENT x86_64 X11_TYPE=modular system, multimedia/libass 
 > 0.11.1 fails to build/replace
 >
 > checking for yasm... yes
 > ...
 > Making all in libass
 >    CC       ass.lo
 > ass.c: In function 'process_info_line':
 > ass.c:609:9: warning: array subscript has type 'char'
 > ass.c: In function 'sub_recode':
 > ass.c:1013:17: warning: passing argument 2 of 'iconv' from incompatible 
 > pointer type
 > /usr/include/iconv.h:46:8: note: expected 'const char ** restrict' but 
 > argument is of type 'char **'
 > ...
 >    CC       ass_strtod.lo
 > ass_strtod.c: In function 'ass_strtod':
 > ass_strtod.c:103:5: warning: array subscript has type 'char'
 > ass_strtod.c:201:9: warning: array subscript has type 'char'
 > /bin/sh ../libtool --quiet --mode=compile "yasm"      -DARCH_X86_64=1 -m 
 > amd64     -o x86/blend_bitmaps.lo x86/blend_bitmaps.asm -prefer-non-pic
 > libtool: compile: unable to infer tagged configuration
 > libtool: compile: specify a tag with `--tag'
 > *** Error code 1
 >
 > Stop.
 > make[2]: stopped in /usr/pkgsrc/multimedia/libass/work/libass-0.11.1/libass
 >
 >> How-To-Repeat:
 >
 >> Fix:
 >
 >
 I'm able to build this with the attached patch on SunOS.
 Seems okay on both i386 and x86_64... buildwise anyway,
 will see about run-time..
 
 --------------010805020209000405080900
 Content-Type: text/x-patch;
  name="libass.patch"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="libass.patch"
 
 diff --git a/multimedia/libass/Makefile b/multimedia/libass/Makefile
 index 3814cee..eea3a29 100644
 --- a/multimedia/libass/Makefile
 +++ b/multimedia/libass/Makefile
 @@ -13,11 +13,18 @@ LICENSE=   isc
  USE_LIBTOOL=          yes
  USE_TOOLS+=           pkg-config
  GNU_CONFIGURE=                yes
 -CONFIGURE_ARGS+=      --disable-asm
  PKGCONFIG_OVERRIDE+=  libass.pc.in
  
  LDFLAGS+=     ${BUILDLINK_LDADD.iconv}
  
 +.include "../../mk/bsd.prefs.mk"
 +.if ${OPSYS} == "SunOS"
 +CONFIGURE_ENV+=       ASFLAGS="-f elf"
 +BUILD_DEPENDS+=       yasm-[0-9]*:../../devel/yasm
 +.else
 +CONFIGURE_ARGS+=      --disable-asm
 +.endif
 +
  BUILDLINK_API_DEPENDS.fribidi+=       fribidi>=0.19.0
  .include "../../converters/fribidi/buildlink3.mk"
  .include "../../converters/libiconv/buildlink3.mk"
 diff --git a/multimedia/libass/distinfo b/multimedia/libass/distinfo
 index 1333ce0..560037a 100644
 --- a/multimedia/libass/distinfo
 +++ b/multimedia/libass/distinfo
 @@ -3,3 +3,4 @@ $NetBSD: distinfo,v 1.5 2014/06/04 10:25:18 adam Exp $
  SHA1 (libass-0.11.2.tar.xz) = 1bffc32d0a601ee6cf289797557bb38636e185b5
  RMD160 (libass-0.11.2.tar.xz) = a82c57d849ccef01b8d0844b03cc9adeeea1469e
  Size (libass-0.11.2.tar.xz) = 297172 bytes
 +SHA1 (patch-libass_Makefile.in) = 825e3c83d02293dabdf1bd2fbe9060d4f3a48adf
 diff --git a/multimedia/libass/patches/patch-libass_Makefile.in 
b/multimedia/libass/patches/patch-libass_Makefile.in
 new file mode 100644
 index 0000000..1f742c4
 --- /dev/null
 +++ b/multimedia/libass/patches/patch-libass_Makefile.in
 @@ -0,0 +1,15 @@
 +$NetBSD$
 +
 +Workaround for libtool missing tag with asm seems to be --tag=CC
 +
 +--- libass/Makefile.in.orig   2014-04-25 17:29:58.000000000 +0000
 ++++ libass/Makefile.in
 +@@ -744,7 +744,7 @@ uninstall-am: uninstall-dist_assheadersH
 + 
 + 
 + .asm.lo:
 +-     $(yasm_verbose)$(LIBTOOL) $(AM_V_lt) --mode=compile $(AS) $(ASFLAGS) -o 
$@ $< -prefer-non-pic
 ++     $(yasm_verbose)$(LIBTOOL) $(AM_V_lt) --mode=compile --tag=CC $(AS) 
$(ASFLAGS) -o $@ $< -prefer-non-pic
 + 
 + # Tell versions [3.59,3.63) of GNU make to not export all variables.
 + # Otherwise a system limit (for SysV at least) may be exceeded.
 
 --------------010805020209000405080900--