Re: pkg/48934: sysutils/hal fails to build on NetBSD 5.2 because of missing POSIX string.h function

[David H.Gutteridge <dhgutteridge%sympatico.ca@localhost>]

The following reply was made to PR pkg/48934; it has been noted by GNATS.

From: David H.Gutteridge <dhgutteridge%sympatico.ca@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/48934: sysutils/hal fails to build on NetBSD 5.2 because of 
missing POSIX string.h function
Date: Sat, 21 Jun 2014 13:51:31 -0400

 On 2014-06-21, at 6:32 AM, David H. Gutteridge wrote:
 
 > On 2014-06-21, at 6:23 AM, David H. Gutteridge wrote:
 >> So it's the addition of the bare __OpenBSD__ that's the problem,
 >> since it will evaluate to false and negate the whole line.
 >=20
 > Perhaps this amendment instead?
 >=20
 > -+#if __FreeBSD_version < 800067 && __DragonFly_version < 200202 && =
 __NetBSD_Version__ < 599001100 && =
 __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ < 1070 && __OpenBSD__
 > ++#if (__FreeBSD_version < 800067 && __DragonFly_version < 200202 && =
 __NetBSD_Version__ < 599001100 && =
 __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ < 1070) || =
 defined(__OpenBSD__)
 >=20
 > Dave
 
 ... There the second clause would be superfluous, because the revised
 first clause would evaluate true on OpenBSD anyway. (Sigh.) The
 __OpenBSD__ check should be further up, where the __MirBSD__ check
 is.
 
 Also, strnlen(3) was added in OpenBSD 4.8. So it too could have a
 version check applied, which from looking at their param.h would be
 "OpenBSD < 201011". (Their version macro is "OpenBSD".)
 
 I'm assuming that this was added because strnlen(3) wasn't found on
 recent versions of OpenBSD, which would presumably be because
 __POSIX_VISIBLE >=3D 200809 has to be true for it to be exposed and it
 isn't set in the pkgsrc build environment.
 
 Dave