Re: pkg/48745: devel/hammer 1.0.0-rc3

[TQ Hirsch <thequux%upstandinghackers.com@localhost>]

The following reply was made to PR pkg/48745; it has been noted by GNATS.

From: TQ Hirsch <thequux%upstandinghackers.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: wiz%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
pkgsrc-bugs%netbsd.org@localhost
Subject: Re: pkg/48745: devel/hammer 1.0.0-rc3
Date: Mon, 14 Apr 2014 03:34:26 -0700

 --nextPart3651804.AxrW9hzYdN
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain; charset="us-ascii"
 
 I seem to have dropped GNATS off the address list.
 On Monday, April 14, 2014
 thequux%upstandinghackers.com@localhost wrote:
 
 > A very minor point about
 >=20
 https://github.com/UpstandingHackers/hammer/commit/849178d60bedbf088424=
 25bc77b428236ab769aa
 >
 > I think a better cast would be to unsigned char, since you already
 > should have checked for -1, and the only other valid values are
 > unsigned char.
 >
 > http://netbsd.gw.com/cgi-bin/man-cgi?ctype++NetBSD-current
 > explains it in more detail.
 
 Thanks for catching this, particularly considering that a negative valu=
 e=20
 will index before the beginning of the ctype array and that function is=
 =20
 designed to handle arbitrary octets. I'll get that fixed.
 
 > What do you want to do about the language plugins for the package?
 > Should they become optional dependencies?
 >
 > Various packages already contain options.mk files if you need
 > inspiration how that's done.
 
 Having the language bindings be optional dependencies makes sense. I'll=
 =20
 get that taken care of by the time we release 1.0.0.=20
 
 =2D-tq
 --nextPart3651804.AxrW9hzYdN
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: This is a digitally signed message part.
 Content-Transfer-Encoding: 7Bit
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.22 (GNU/Linux)
 
 iQIcBAABAgAGBQJTS7m+AAoJEMJiybL6ZasR23UP/0uqAcfBsIpvq0liRG3x0E7K
 AA9cGBV5k/TQNjJSTUhn/q65ntTz+g9PE7WwlCbGef84F8aJMi9euVky7a0AIWYZ
 SbJBSIz7+QOiLLnJH0gntyUNzkANYK26ieltF6BtV5EqV9KXQuJEDPC3mz4f//Xz
 RXYmav+TJJgNqKUSjBPYnE+KmuS7CeNtboc3lcCcoZY2BjJwwy+X2ZI1u0WAjSAZ
 moyeg9z/2vJVJPASsXvvNc3qCjh/uysOIskmzXbCddtaiJp+kH5oBM8XPbsQ5YOT
 +3OistaVKmwC5jO9q0tdSJbxR42K45TLCk3R7lhpcrCA39ouA7ApbeqjnDemCs6L
 rCliVrOE4pv2v0oCW3617e70ybRWHZulMBupgiTQtXH/XX1dfOzrG4pkiZhaoMSW
 TECiLABo8W77G1E//3HWtSs/aQe4PbR8vygd8ithNZ36UMUaZcWHTs3Ob7+rQ4WB
 0n7nzs6z5b418vkd3qhAddZsRlM4VgsYwizuJIgaYelK4OD6O8ArHphQYCYKNsbP
 cYwaFAKiYGqUl/X1Ha6ca8S/BODaPmYg420jpkEpWZ24/AJ+Kd3pCyBtanfflPkC
 A/w8A8/Pguw4c7J+6Q4QJAbafFlEXgaAyBmjmXA5EmRiJUl/n6SFUbeHb+0x4gsE
 bFgSZwmc+/a+EDXTuhnC
 =kmhU
 -----END PGP SIGNATURE-----
 
 --nextPart3651804.AxrW9hzYdN--