Re: pkg/48075 (compilation of devel/gtexinfo fails)

[Tim Zingelman <zingelman%gmail.com@localhost>]

The following reply was made to PR pkg/48075; it has been noted by GNATS.

From: Tim Zingelman <zingelman%gmail.com@localhost>
To: NetBSD bugtracking <gnats-bugs%netbsd.org@localhost>
Cc: solaris-pkg-people%netbsd.org@localhost, pkg-manager%netbsd.org@localhost, 
        pkgsrc-bugs%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
        Thomas Klausner <wiz%netbsd.org@localhost>, 
=?ISO-8859-1?Q?J=F6rn_C=2E?= <joern.clausen%uni-bielefeld.de@localhost>, 
        Amitai Schlair <schmonz%netbsd.org@localhost>
Subject: Re: pkg/48075 (compilation of devel/gtexinfo fails)
Date: Fri, 3 Jan 2014 15:53:48 -0600

 I have tracked this down to where adding a single space to the script
 works around the bug in pdksh that this is triggering (or fixes the
 bad syntax that sh & ksh accept)
 
 I just tried this on a NetBSD 5.1 i386 machine, and if you set:
 TOOLS_PLATFORM.sh?=             /usr/pkg/bin/pdksh
 TOOLS_PLATFORM.ksh?=            /usr/pkg/bin/pdksh
 (or just edit the texti2dvi script to use /usr/pkg/bin/pdksh) the same
 problem occurs.
 
 Editing the texi2dvi and adding a single space as shown in this diff
 makes pdksh work:
 
 --- texi2dvi.saved      Fri Jan  3 15:00:27 2014
 +++ texi2dvi    Fri Jan  3 15:29:17 2014
 @@ -1103,7 +1103,7 @@
    # bibtex would never be run.
    if test -r "$in_noext.aux" \
       && test -r "$in_noext.log" \
 -     && ((grep 'Warning:.*Citation.*undefined' "$in_noext.log" \
 +     && ( (grep 'Warning:.*Citation.*undefined' "$in_noext.log" \
            || grep '.*Undefined citation' "$in_noext.log" \
            || grep 'No file .*\.bbl\.' "$in_noext.log") \
            || (grep 'No \.aux file' "$in_noext.log" \
 
 
 I think this should be re-assigned to the maintainer of pdksh.
 Perhaps meanwhile the line:
 
 REPLACE_SH+=            util/texi2dvi
 
 should be conditionalized to avoid this issue at least on SunOS.
 
  - Tim