Re: pkg/48398 (x11/kde-workspace4 fails to build on NetBSD-6.1.2/amd64)

[Mark Davies <mark%ecs.vuw.ac.nz@localhost>]

The following reply was made to PR pkg/48398; it has been noted by GNATS.

From: Mark Davies <mark%ecs.vuw.ac.nz@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/48398 (x11/kde-workspace4 fails to build on NetBSD-6.1.2/amd64)
Date: Thu, 12 Dec 2013 11:39:43 +1300

 On Thursday 12 December 2013 10:00:01 you wrote:
 >  >  So is this a native X vs modular X build issue?
 >  That is my understanding, yes.  (I'm using native X)
 
 How about these patches that just skip it if the glxext version is too 
 old?
 
 cheers
 mark
 
 $NetBSD$
 
 --- kwin/glxbackend.cpp.orig   2013-09-26 19:18:26.000000000 +0000
 +++ kwin/glxbackend.cpp
 @@ -152,6 +152,7 @@ bool GlxBackend::initRenderingContext()
  {
      bool direct = options->isGlDirect();
  
 +#if GLX_GLXEXT_VERSION >= 32
      // Use glXCreateContextAttribsARB() when it's available
      if (glXCreateContextAttribsARB) {
          const int attribs_31_core_robustness[] = {
 @@ -197,6 +198,7 @@ bool GlxBackend::initRenderingContext()
          if (!ctx)
              ctx = glXCreateContextAttribsARB(display(), fbconfig, 0, 
 direct, attribs_legacy);
      }
 +#endif
  
      if (!ctx)
          ctx = glXCreateNewContext(display(), fbconfig, GLX_RGBA_TYPE, 
 NULL, direct);
 $NetBSD$
 
 --- kwin/scene_opengl.cpp.orig 2013-09-26 19:18:26.000000000 +0000
 +++ kwin/scene_opengl.cpp
 @@ -293,6 +293,7 @@ void SceneOpenGL::copyPixels(const QRegi
  }
  #endif
  
 +#if GLX_GLXEXT_VERSION >= 32
  #ifndef KWIN_HAVE_OPENGLES
  #  define GL_GUILTY_CONTEXT_RESET_KWIN    GL_GUILTY_CONTEXT_RESET_ARB
  #  define GL_INNOCENT_CONTEXT_RESET_KWIN  GL_INNOCENT_CONTEXT_RESET_ARB
 @@ -302,9 +303,11 @@ void SceneOpenGL::copyPixels(const QRegi
  #  define GL_INNOCENT_CONTEXT_RESET_KWIN  GL_INNOCENT_CONTEXT_RESET_EXT
  #  define GL_UNKNOWN_CONTEXT_RESET_KWIN   GL_UNKNOWN_CONTEXT_RESET_EXT
  #endif
 +#endif
  
  void SceneOpenGL::handleGraphicsReset(GLenum status)
  {
 +#if GLX_GLXEXT_VERSION >= 32
      switch (status) {
      case GL_GUILTY_CONTEXT_RESET_KWIN:
          kDebug(1212) << "A graphics reset attributable to the current GL 
 context occurred.";
 @@ -321,6 +324,7 @@ void SceneOpenGL::handleGraphicsReset(GL
      default:
          break;
      }
 +#endif
  
      QElapsedTimer timer;
      timer.start();