Re: pkg/48375: etckeeper fails to run with /bin/sh

[Kimmo Suominen <kim%netbsd.org@localhost>]

The following reply was made to PR pkg/48375; it has been noted by GNATS.

From: Kimmo Suominen <kim%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/48375: etckeeper fails to run with /bin/sh
Date: Sun, 10 Nov 2013 09:59:17 +0200

 --527f3cd5_2d1d5ae9_f8a7
 Content-Type: text/plain; charset="utf-8"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 On Sun, 10 Nov 2013 at 5:50, Robert Elz wrote:
 > If there's a variable that's being unset, without ever being set, just
 > install a patch to set the thing before the unset happens, and no more
 > problems, that is, if
 > 
 > unset x
 > 
 > is the issue, just make it be
 > 
 > x= ; unset x
 > 
 > and we're done.
 
 I considered that, but thought that it is not the best approach due to the 
architecture of etckeeper: each etckeeper command actually maps to a directory, 
which contains any number of scripts to execute. 3rd-party scripts might have 
adopted the same style of unsetting things that have not been set, and would 
fail.
 
 On top of that, the failure mode is very unfriendly: the command just exits 
with an exit code of 1. There is no error message, even.
 
 + Kimmo
  
 
 
 --527f3cd5_2d1d5ae9_f8a7
 Content-Type: text/html; charset="utf-8"
 Content-Transfer-Encoding: quoted-printable
 Content-Disposition: inline
 
 
                 <div style=3D=22font-family: Helvetica; font-size: 13px;=22=
 ><span style=3D=22color: rgb(160, 160, 168);=22>On Sun, 10 Nov 2013 at 5:=
 50, Robert Elz wrote:</span></div>
                 <blockquote type=3D=22cite=22 style=3D=22border-left-styl=
 e:solid;border-width:1px;margin-left:0px;padding-left:10px;=22>
                     <span><div>If there's a variable that's being unset, =
 without ever being set, just</div><div> install a patch to set the thing =
 before the unset happens, and no more</div><div> problems, that is, if</d=
 iv><div> </div><div>   unset x</div><div> </div><div> is the issue, just m=
 ake it be</div><div> </div><div>       x=3D ; unset x</div><div> </div><div> a=
 nd we're done.</div></span></blockquote><div>I considered that, but thoug=
 ht that it is not the best approach due to the architecture of etckeeper:=
  each etckeeper command actually maps to a directory, which contains any =
 number of scripts to execute. 3rd-party scripts might have adopted the sa=
 me style of unsetting things that have not been set, and would fail.</div=
 ><div><br></div><div>On top of that, the failure mode is very unfriendly:=
  the command just exits with an exit code of 1. There is no error message=
 , even.</div><div><br></div><div>+ Kimmo</div><div>&nbsp;</div>
                 =20
                 <div>
                     <br>
                 </div>
             
 --527f3cd5_2d1d5ae9_f8a7--