pkg/48100: xl2tpd does not compile on NetBSD-6.1 - missing #define

[gergely%egervary.hu@localhost]

>Number:         48100
>Category:       pkg
>Synopsis:       xl2tpd does not compile on NetBSD-6.1 - missing #define
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jul 30 17:20:00 +0000 2013
>Originator:     Gergely Egervary
>Release:        NetBSD 6.1
>Organization:
>Environment:
NetBSD galileo.poli.hu 6.1 NetBSD 6.1 (GALILEO) #3: Sun Jun  9 13:58:31 CEST 
2013  root%galileo.poli.hu@localhost:/usr/src/sys/arch/amd64/compile/GALILEO 
amd64

>Description:
| ===> Building for xl2tpd-20130626
| gcc -O2 -DDEBUG_PPPD -DTRUST_PPPD_TO_DIE -O2 -fno-builtin -Wall 
| -DSANITY -DNETBSD -DIP_ALLOCATION  -c pty.c
|
| In file included from /usr/include/util.h:43:0,
|                 from pty.c:47:
| /usr/include/utmpx.h:115:26: error: field 'ut_ss' has incomplete type

ut_ss has type sockaddr_storage defined in <sys/socket.h>, but header only 
defines it if:
#if (_XOPEN_SOURCE - 0) >= 500 || defined(_NETBSD_SOURCE)

placing this #define into pty.c fixes problem:

--- pty.c.orig  2013-06-17 12:17:24.000000000 +0200
+++ pty.c       2013-07-30 19:13:19.000000000 +0200
@@ -17,6 +17,7 @@
 #define _ISOC99_SOURCE
 #define _XOPEN_SOURCE
 #define _BSD_SOURCE
+#define _NETBSD_SOURCE
 #define _XOPEN_SOURCE_EXTENDED

>How-To-Repeat:

>Fix:
--- pty.c.orig  2013-06-17 12:17:24.000000000 +0200
+++ pty.c       2013-07-30 19:13:19.000000000 +0200
@@ -17,6 +17,7 @@
 #define _ISOC99_SOURCE
 #define _XOPEN_SOURCE
 #define _BSD_SOURCE
+#define _NETBSD_SOURCE
 #define _XOPEN_SOURCE_EXTENDED