pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/48074: libgdiplus fails build with the latest giflib



The following reply was made to PR pkg/48074; it has been noted by GNATS.

From: "OBATA Akio" <obache%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/48074: libgdiplus fails build with the latest giflib
Date: Tue, 23 Jul 2013 22:23:47 +0900

 On Tue, 23 Jul 2013 22:10:01 +0900, Mihai Chelaru 
<kefren%netbsd.org@localhost> wrote:
 
 >  Any reason why not using GIFLIB_MAJOR everywhere in this patch instead
 >  of checking for GIF_LIB_VERSION (@39) and the other couple of places
 >  @192, @232 ?
 
 GIF_LIB_VERSION is defined in 4.1.6 and prior.
 GIFLIB_MAJOR is defined after 4.1.6 (include 4.2.x).
 
 Then...
 GIF_LIB_VERSION must be used for version check before 4.1.6,
 GIFLIB_MAJOR must be used for version check after 4.1.6.
 
 >  I'm not a GIF expert myself, but the changeset looks ok to me, so if
 >  it works for you and PR reporter please commit it.
 
 Me too.
 I've patched some of them, and I'm not sure those are correct or not.
 
 Here are some information about `Forward and Backward Compatibility' of giflib:
   http://giflib.sourceforge.net/gif_lib.html#compatibility
 
 -- 
 OBATA Akio / obache%NetBSD.org@localhost
 


Home | Main Index | Thread Index | Old Index