pkg/47873: "rtorrent" package can no longer be built with GCC 4.1.2

[tron%zhadum.org.uk@localhost]

>Number:         47873
>Category:       pkg
>Synopsis:       "rtorrent" package can no longer be built with GCC 4.1.2
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jun 01 14:55:00 +0000 2013
>Originator:     Matthias Scheler
>Release:        Darwin 11.4.2
>Organization:
Matthias Scheler                                  http://zhadum.org.uk/
>Environment:
System: Darwin excalibur.zhadum.org.uk 11.4.2 Darwin Kernel Version 11.4.2: Thu 
Aug 23 16:26:45 PDT 2012; root:xnu-1699.32.7~1/RELEASE_I386 i386
Architecture: i386
Machine: i396

>Description:
The following commit broke the build of the "rtorrent" package under
system that use GCC 4.1.2 like Mac OS X Lion:

http://mail-index.netbsd.org/pkgsrc-changes/2013/05/09/msg088870.html

Here is the output of the build failure:

g++ -DHAVE_CONFIG_H -I. -I../.. -I. -I./.. -I../..  -isystem /usr/include 
-I/usr/include -I/usr/pkg/include -I/usr/pkg/include/gettext  -pipe -O2 
-I/usr/include -I/usr/pkg/include -I/usr/pkg/include/gettext -march=i486 -g 
-DDEBUG -D_THREAD_SAFE  -D_REENTRANT  -I/usr/pkg/include/sigc++-2.0 
-I/usr/pkg/lib/sigc++-2.0/include  -I/usr/pkg/include  -I/usr/pkg/include  -MT 
curl_stack.o -MD -MP -MF .deps/curl_stack.Tpo -c -o curl_stack.o curl_stack.cc
g++ -DHAVE_CONFIG_H -I. -I../.. -I. -I./.. -I../..  -isystem /usr/include 
-I/usr/include -I/usr/pkg/include -I/usr/pkg/include/gettext  -pipe -O2 
-I/usr/include -I/usr/pkg/include -I/usr/pkg/include/gettext -march=i486 -g 
-DDEBUG -D_THREAD_SAFE  -D_REENTRANT  -I/usr/pkg/include/sigc++-2.0 
-I/usr/pkg/lib/sigc++-2.0/include  -I/usr/pkg/include  -I/usr/pkg/include  -MT 
dht_manager.o -MD -MP -MF .deps/dht_manager.Tpo -c -o dht_manager.o 
dht_manager.cc
g++ -DHAVE_CONFIG_H -I. -I../.. -I. -I./.. -I../..  -isystem /usr/include 
-I/usr/include -I/usr/pkg/include -I/usr/pkg/include/gettext  -pipe -O2 
-I/usr/include -I/usr/pkg/include -I/usr/pkg/include/gettext -march=i486 -g 
-DDEBUG -D_THREAD_SAFE  -D_REENTRANT  -I/usr/pkg/include/sigc++-2.0 
-I/usr/pkg/lib/sigc++-2.0/include  -I/usr/pkg/include  -I/usr/pkg/include  -MT 
download.o -MD -MP -MF .deps/download.Tpo -c -o download.o download.cc
g++ -DHAVE_CONFIG_H -I. -I../.. -I. -I./.. -I../..  -isystem /usr/include 
-I/usr/include -I/usr/pkg/include -I/usr/pkg/include/gettext  -pipe -O2 
-I/usr/include -I/usr/pkg/include -I/usr/pkg/include/gettext -march=i486 -g 
-DDEBUG -D_THREAD_SAFE  -D_REENTRANT  -I/usr/pkg/include/sigc++-2.0 
-I/usr/pkg/lib/sigc++-2.0/include  -I/usr/pkg/include  -I/usr/pkg/include  -MT 
download_factory.o -MD -MP -MF .deps/download_factory.Tpo -c -o 
download_factory.o download_factory.cc
g++ -DHAVE_CONFIG_H -I. -I../.. -I. -I./.. -I../..  -isystem /usr/include 
-I/usr/include -I/usr/pkg/include -I/usr/pkg/include/gettext  -pipe -O2 
-I/usr/include -I/usr/pkg/include -I/usr/pkg/include/gettext -march=i486 -g 
-DDEBUG -D_THREAD_SAFE  -D_REENTRANT  -I/usr/pkg/include/sigc++-2.0 
-I/usr/pkg/lib/sigc++-2.0/include  -I/usr/pkg/include  -I/usr/pkg/include  -MT 
download_list.o -MD -MP -MF .deps/download_list.Tpo -c -o download_list.o 
download_list.cc
g++ -DHAVE_CONFIG_H -I. -I../.. -I. -I./.. -I../..  -isystem /usr/include 
-I/usr/include -I/usr/pkg/include -I/usr/pkg/include/gettext  -pipe -O2 
-I/usr/include -I/usr/pkg/include -I/usr/pkg/include/gettext -march=i486 -g 
-DDEBUG -D_THREAD_SAFE  -D_REENTRANT  -I/usr/pkg/include/sigc++-2.0 
-I/usr/pkg/lib/sigc++-2.0/include  -I/usr/pkg/include  -I/usr/pkg/include  -MT 
download_store.o -MD -MP -MF .deps/download_store.Tpo -c -o download_store.o 
download_store.cc
curl_stack.cc: In constructor 'core::CurlStack::CurlStack()':
curl_stack.cc:58: error: cannot convert 'void (core::CurlStack::*)()' to 'int' 
for argument '1' to 'int bind(int, const sockaddr*, socklen_t)'
mv -f .deps/curl_socket.Tpo .deps/curl_socket.Po
g++ -DHAVE_CONFIG_H -I. -I../.. -I. -I./.. -I../..  -isystem /usr/include 
-I/usr/include -I/usr/pkg/include -I/usr/pkg/include/gettext  -pipe -O2 
-I/usr/include -I/usr/pkg/include -I/usr/pkg/include/gettext -march=i486 -g 
-DDEBUG -D_THREAD_SAFE  -D_REENTRANT  -I/usr/pkg/include/sigc++-2.0 
-I/usr/pkg/lib/sigc++-2.0/include  -I/usr/pkg/include  -I/usr/pkg/include  -MT 
http_queue.o -MD -MP -MF .deps/http_queue.Tpo -c -o http_queue.o http_queue.cc
gnumake[3]: *** [curl_stack.o] Error 1
gnumake[3]: *** Waiting for unfinished jobs....
download_list.cc: In member function 'std::_List_iterator<core::Download*> 
core::DownloadList::insert(core::Download*)':
download_list.cc:184: error: cannot convert 'void 
(core::DownloadList::*)(core::Download*)' to 'int' for argument '1' to 'int 
bind(int, const sockaddr*, socklen_t)'
download_list.cc:185: error: cannot convert 'void 
(core::DownloadList::*)(core::Download*)' to 'int' for argument '1' to 'int 
bind(int, const sockaddr*, socklen_t)'
mv -f .deps/curl_get.Tpo .deps/curl_get.Po
gnumake[3]: *** [download_list.o] Error 1
mv -f .deps/download_store.Tpo .deps/download_store.Po
mv -f .deps/download.Tpo .deps/download.Po
mv -f .deps/dht_manager.Tpo .deps/dht_manager.Po
http_queue.cc: In member function 'std::_List_iterator<core::CurlGet*> 
core::HttpQueue::insert(const std::string&, std::iostream*)':
http_queue.cc:61: error: cannot convert 'void 
(core::HttpQueue::*)(std::_List_iterator<core::CurlGet*>)' to 'int' for 
argument '1' to 'int bind(int, const sockaddr*, socklen_t)'
http_queue.cc:62: error: cannot convert 'void 
(core::HttpQueue::*)(std::_List_iterator<core::CurlGet*>)' to 'int' for 
argument '1' to 'int bind(int, const sockaddr*, socklen_t)'
gnumake[3]: *** [http_queue.o] Error 1
mv -f .deps/download_factory.Tpo .deps/download_factory.Po
gnumake[2]: *** [all-recursive] Error 1
gnumake[1]: *** [all-recursive] Error 1
gnumake: *** [all] Error 2
*** Error code 2

These changes were *not* presented to the owner of the package for review.

>How-To-Repeat:
cd pkgsrc/net/rtorrent
bmake

>Fix:
Reverting the following two commits should fix the problem:

http://mail-index.netbsd.org/pkgsrc-changes/2013/05/09/msg088871.html
http://mail-index.netbsd.org/pkgsrc-changes/2013/05/09/msg088870.html