pkg/47870: math/nickle DragonFly readline USE_GNU_READLINE error: 'rl_catch_signals' undeclared

[davshao%gmail.com@localhost]

>Number:         47870
>Category:       pkg
>Synopsis:       math/nickle DragonFly readline USE_GNU_READLINE error: 
>'rl_catch_signals' undeclared
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu May 30 16:15:00 +0000 2013
>Originator:     David Shao
>Release:        DragonFly 3.5-DEVELOPMENT i386 x86_64
>Organization:
>Environment:
DragonFly 3.5-DEVELOPMENT i386 x86_64
>Description:
On DragonFly 3.5-DEVELOPMENT i386 x86_64, using pkgsrc current master as of:

commit fedde632eeb4be1af41e44806398d8a57bb857a0
Date:   Thu May 30 06:34:42 2013 -0700

math/nickle fails to build:

checking for tparm in -lncurses... no
checking for tgetent in -ltermcap... yes
checking for readline in -lreadline... yes
checking readline/readline.h usability... yes
checking readline/readline.h presence... yes
checking for readline/readline.h... yes
checking whether rl_catch_signals is declared... no
checking whether rl_reset_after_signal is declared... no
checking whether rl_cleanup_after_signal is declared... yes
...
cc -DHAVE_CONFIG_H -I.  -DBUILD=\"""\"  -DBUILD_VERSION=\""2.77"\"  
-DLOCAL_BUILD  -DNICKLELIBDIR=\"/usr/pkg/share/nickle\"  -I/usr/include 
-D_FORTIFY_SOURCE=2 -O2  -Wall -Wpointer-arith -Wstrict-prototypes  
-Wmissing-prototypes -Wmissing-declarations  -Wnested-externs 
-fno-strict-aliasing -fwrapv -O2 -g -I/usr/include -MT lex.o -MD -MP -MF 
.deps/lex.Tpo -c -o lex.o lex.c
lex.l: In function 'LexInit':
lex.l:129:27: warning: assignment from incompatible pointer type [enabled by 
default]
lex.l:131:5: error: 'rl_catch_signals' undeclared (first use in this function)
lex.l:131:5: note: each undeclared identifier is reported only once for each 
function it appears in
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/math/nickle/work/nickle-2.77
*** Error code 1

The Makefile for math/nickle was recently changed so that 
USE_GNU_READLINE=       yes
is set only for certain versions of NetBSD, whereas previously it appears to 
have been the default for everyone.

>How-To-Repeat:

>Fix:
Changing the Makefile by adding

.if (${OPSYS} == DragonFly)
USE_GNU_READLINE= yes
.endif

enabled math/nickle to build on both DragonFly 3.5-DEVELOPMENT i386 x86_64.  
However instead of trying to guess whether each OS needs USE_GNU_READLINE, 
perhaps it would be better, if possible, to have USE_GNU_READLINE set or not 
controlled by an option in options.mk.