pkg/47868: www/libproxy does not compile on Solaris 10

[joern.clausen%uni-bielefeld.de@localhost]

>Number:         47868
>Category:       pkg
>Synopsis:       www/libproxy does not compile on Solaris 10
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed May 29 15:00:00 +0000 2013
>Originator:     Jörn Clausen
>Release:        
>Organization:
University of Bielefeld
>Environment:
>Description:
Compiling www/libproxy on Solaris fails, because libsocket and libnsl are not 
linked. The line

LIBS.SunOS+=    -lnsl -lsocket

is ignored. Maybe at some time in the past libproxy did not use cmake.

In addition, the unrecognized linker flag "--no-as-needed" is used in 
libmodman/test.

>How-To-Repeat:

>Fix:
To fix the first problem, this line has to be added to CMakeLists.txt:

set(CMAKE_EXE_LINKER_FLAGS "-lnsl -lsocket")

To fix the second problem, this part in libmodman/test/CMakeLists.txt has to be 
changed:

    if(NOT WIN32 AND NOT APPLE)
      set_property(TARGET ${name} PROPERTY
                   LINK_FLAGS -Wl,--no-as-needed)
    endif()


I have not found a way to enclose the first fix in an appropriate condition or 
to extend the second condition appropriately. I tested the fix by adding the 
first and removing the second piece of code unconditionally. Someone with more 
knowledge of CMake has to provide the missing parts.

I have not reported this upstream, because when compiling the same sources 
outside of pkgsrc, I see completely different errors in other parts of the 
sources.