pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

pkg/47836: Patch for lldpd to support options framework and xml option. Some cleaning up.



>Number:         47836
>Category:       pkg
>Synopsis:       Patch for lldpd to support options framework and xml option. 
>Some cleaning up.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun May 19 11:20:01 +0000 2013
>Originator:     Bartek Krawczyk
>Release:        6.1_RC4
>Organization:
>Environment:
NetBSD test.krawczyk.it 6.1_RC4 NetBSD 6.1_RC4 (XEN3_DOMU) amd64
>Description:
Please find attached a patch for lately imported lldpd package. It adds options 
support and initial "xml" option. It also cleans some things with user and 
group.
It's my first patch so please review it.


>How-To-Repeat:

>Fix:
@@ -22,8 +22,10 @@
 CONFIGURE_ARGS+=       --with-privsep-chroot=${PKG_HOME._lldpd}
 
 RCD_SCRIPTS=           lldpd
-PKG_GROUPS=            _lldpd
-PKG_USERS=             _lldpd:_lldpd
+LLDPD_USER?=   _lldpd
+LLDPD_GROUP?=  _lldpd
+PKG_GROUPS=            ${LLDPD_GROUP}
+PKG_USERS=             ${LLDPD_USER}:${LLDPD_GROUP}
 PKG_HOME._lldpd=       ${VARBASE}/chroot/lldpd
 
 OWN_DIRS=              ${VARBASE}/chroot/lldpd
@@ -31,6 +33,8 @@
 
 INSTALLATION_DIRS+=    sbin ${PKGMANDIR}/man5 ${PKGMANDIR}/man8
 
+.include "options.mk"
+
 BUILDLINK_API_DEPENDS.libevent+=       libevent>=2.0.5
 .include "../../devel/libevent/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk







--- empty       2013-05-19 12:47:18.000000000 +0200
+++ options.mk  2013-05-19 12:44:38.000000000 +0200
@@ -0,0 +1,9 @@
+PKG_OPTIONS_VAR=       PKG_OPTIONS.lldpd
+PKG_SUPPORTED_OPTIONS= xml
+PKG_SUGGESTED_OPTIONS=
+.include "../../mk/bsd.options.mk"
+
+.if !empty(PKG_OPTIONS:Mxml)
+.      include "../../textproc/libxml2/buildlink3.mk"
+CONFIGURE_ARGS+=       --with-xml
+.endif



Home | Main Index | Thread Index | Old Index