Re: pkg/34215 (games/grhino)

[Patrick Welche <prlw1%cam.ac.uk@localhost>]

The following reply was made to PR pkg/34215; it has been noted by GNATS.

From: Patrick Welche <prlw1%cam.ac.uk@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: prlw1%NetBSD.org@localhost, pkg-manager%netbsd.org@localhost, 
pkgsrc-bugs%netbsd.org@localhost,
        gnats-admin%netbsd.org@localhost, bsiegert%NetBSD.org@localhost,
        Gilles Dauphin <dauphin%enst.fr@localhost>
Subject: Re: pkg/34215 (games/grhino)
Date: Sun, 7 Apr 2013 09:39:42 +0100

 --Dxnq1zWXvFF0Q93v
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 This isn't actually a GNOME program but I'll take a look anyway ;-)
 
 Agreed that the patches look good - the thing that bothers me is that it
 doesn't lead to an upstream fix.
 
 The underlying problem is that -e doesn't exist (pun?) in Solaris' sh.
 However, -d does, and all the tests are against directories.
 
 Does the attached work for you? (here be tabs)
 
 --Dxnq1zWXvFF0Q93v
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="patch-Makefile.in"
 
 $NetBSD$
 
 --- Makefile.in.orig   2013-04-07 08:31:30.000000000 +0000
 +++ Makefile.in
 @@ -452,43 +452,43 @@ distclean : distclean_curdir
        $(adBeginSubdir) $@ $(adEndSubdir)
  
  install_mkdir :
 -      if [ ! -e "$(DESTDIR)$(bindir)" ]; then         \
 +      if [ ! -d "$(DESTDIR)$(bindir)" ]; then         \
                mkdir -p "$(DESTDIR)$(bindir)";         \
                chmod 755 "$(DESTDIR)$(bindir)";                \
        fi
 -      if [ ! -e "$(DESTDIR)$(icon_dir)" ]; then               \
 +      if [ ! -d "$(DESTDIR)$(icon_dir)" ]; then               \
                mkdir -p "$(DESTDIR)$(icon_dir)";               \
                chmod 755 "$(DESTDIR)$(icon_dir)";      \
        fi
 -      if [ ! -e "$(DESTDIR)$(pattern_dir)" ]; then    \
 +      if [ ! -d "$(DESTDIR)$(pattern_dir)" ]; then    \
                mkdir -p "$(DESTDIR)$(pattern_dir)";    \
                chmod 755 "$(DESTDIR)$(pattern_dir)";   \
        fi
 -      if [ ! -e "$(DESTDIR)$(book_dir)" ]; then               \
 +      if [ ! -d "$(DESTDIR)$(book_dir)" ]; then               \
                mkdir -p "$(DESTDIR)$(book_dir)";               \
                chmod 755 "$(DESTDIR)$(book_dir)";      \
        fi
 -      if [ ! -e "$(DESTDIR)$(theme_dir)" ]; then      \
 +      if [ ! -d "$(DESTDIR)$(theme_dir)" ]; then      \
                mkdir -p "$(DESTDIR)$(theme_dir)";      \
                chmod 755 "$(DESTDIR)$(theme_dir)";     \
        fi
 -      if [ ! -e "$(DESTDIR)$(theme_dir)/small" ]; then        \
 +      if [ ! -d "$(DESTDIR)$(theme_dir)/small" ]; then        \
                mkdir -p "$(DESTDIR)$(theme_dir)/small";        \
                chmod 755 "$(DESTDIR)$(theme_dir)/small";       \
        fi
 -      if [ ! -e "$(DESTDIR)$(omfdir)" ]; then         \
 +      if [ ! -d "$(DESTDIR)$(omfdir)" ]; then         \
                mkdir -p "$(DESTDIR)$(omfdir)";         \
                chmod 755 "$(DESTDIR)$(omfdir)";                \
        fi
 -      if [ ! -e "$(DESTDIR)$(helpdir)" ]; then                \
 +      if [ ! -d "$(DESTDIR)$(helpdir)" ]; then                \
                mkdir -p "$(DESTDIR)$(helpdir)";                \
                chmod 755 "$(DESTDIR)$(helpdir)";               \
        fi
 -      if [ ! -e "$(DESTDIR)$(helpdir)/C" ]; then      \
 +      if [ ! -d "$(DESTDIR)$(helpdir)/C" ]; then      \
                mkdir -p "$(DESTDIR)$(helpdir)/C";      \
                chmod 755 "$(DESTDIR)$(helpdir)/C";     \
        fi
 -      if [ ! -e "$(DESTDIR)$(helpdir)/C/figures" ]; then  \
 +      if [ ! -d "$(DESTDIR)$(helpdir)/C/figures" ]; then  \
                mkdir -p "$(DESTDIR)$(helpdir)/C/figures";  \
                chmod 755 "$(DESTDIR)$(helpdir)/C/figures"; \
        fi
 
 --Dxnq1zWXvFF0Q93v--