Re: pkg/28761

[Robert Elz <kre%munnari.OZ.AU@localhost>]

The following reply was made to PR pkg/28761; it has been noted by GNATS.

From: Robert Elz <kre%munnari.OZ.AU@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/28761
Date: Tue, 26 Mar 2013 21:42:48 +0700

     Date:        Tue, 26 Mar 2013 13:35:03 +0000 (UTC)
     From:        Benny Siegert <bsiegert%gmail.com@localhost>
     Message-ID:  <20130326133503.3D5E863E6F8%www.NetBSD.org@localhost>
 
   |  Ping.
 
 Pong.
 
 Now the frivolity is out of the way, I still believe that clean-depends
 should really act the way I requested.
 
 However, I care much less now - when the PR was sent (> 8 years ago)
 I don't think I was using obj directories for pkgsrc, just work (or work.arch
 if that existed yet) inside pkgsrc, and "make clean" was actually
 important.   Now with obj directories, I don't bother with make clean
 any more, "rm -fr /usr/obj/pkg/*" (or whatever subset of that I feel
 inclined to clean) is infinitely faster, and barely any harder to type.
 
 I also removed all instances of "make clean" from the version of pkg_comp
 I use (I think I made them optional, under an option I do not enable), and
 I also changed the do-bin-install-from-source target in
 pkgsrc/mk/install/bin-install.mk to remove the part that does
        ${RECURSIVE_MAKE} ${MAKEFLAGS} clean
 
 With those changes, I never see a "make clean" any more, so I no longer
 really care if it is sane or not, so if you really want to close
 this ancient PR, then I guess you can go ahead and do that.
 
 Incidentally, that "${RECURSIVE_MAKE} ${MAKEFLAGS} clean" was the source
 of the "make clean twice" that I had reported (or mentioned) in  some
 context or other sometime in the past - pkg_comp does "make" then (did anyway)
 "make clean", I have DEPENDS_TARGET=bin-install in (pkg_comp's) mk.conf
 so the make was doing "make bin-install", and that was causing a complete
 clean for every package installed 999% of which were the "bin" variety
 of the "bin-install-from-source" when they're dependencies - that is, I
 would have all the dependencies built as bin-pkgs already, then pkgsrc
 would (quickly) install the dependencies, and (absurdly slowly) do a
 "make clean" (recursively, that is, effectively CLEANDEPENDS=yes) on
 each one of them...   Then once the build had finished, pkg_comp did its
 make clean, including the dependencies, which cleaned all of the binpkgs
 (and their dependencies) all over again, and all for nothing!
 
 With the change I requested, that would have been relatively fast, as
 nothing was built, nothing would have been cleaned, and I might never have
 noticed the "install then clean" behaviour of pkgsrc.
 
 kre