pkg/47662: x11/renderproto Malformed conditional

[maarten%mdammers.nl@localhost]

>Number:         47662
>Category:       pkg
>Synopsis:       x11/renderproto Malformed conditional
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Mar 17 13:15:00 +0000 2013
>Originator:     Maarten Dammers
>Release:        NetBSD 5.0.1
>Organization:
>Environment:
NetBSD <hostname> 5.0.1 NetBSD 5.0.1 (GENERIC) #0: Thu Jul 30 00:08:07 UTC 2009 
 
builds%b7.netbsd.org@localhost:/home/builds/ab/netbsd-5-0-1-RELEASE/amd64/200907292356Z-obj/home/builds/ab/netbsd-5-0-1-RELEASE/src/sys/arch/amd64/compile/GENERIC
 amd64
>Description:
The package x11/renderproto seems to be a dependency. When I do a 

make clean-depends (1.15)

===> Cleaning for digest-20121220
===> Cleaning for f2c-20100903
make: "../../x11/renderproto/../../x11/renderproto/buildlink3.mk" line 14: 
Malformed conditional (${BUILTIN_X11_TYPE.native} == "XFree86" ||  
${BUILTIN_X11_TYPE.native} == "xorg" &&  empty(BUILTIN_X11_VERSION.xorg))
make: "../../x11/renderproto/../../x11/renderproto/buildlink3.mk" line 14: 
Missing dependency operator
===> Cleaning for libtool-base-2.2.6bnb8
===> Cleaning for pkg-config-0.28
make: Fatal errors encountered -- cannot continue
make: don't know how to make show-depends-pkgpaths. Stop
test: stopped: unexpected operator
test: stopped: unexpected operator
===> Cleaning for perl-5.16.2nb4
cd: bad substitution
===> x11
===> x11/9term
===> Cleaning for 9term-1.6.3nb1
===> x11/XaoS
===> Cleaning for xaos-3.5nb1
===> x11/Xaw-Xpm
===> Cleaning for Xaw-Xpm-1.1nb4
===> x11/Xaw3d
===> Cleaning for Xaw3d-1.5Enb4
===> x11/Xbae
===> Cleaning for Xbae-4.51.01nb3
===> x11/Xcomposite
===> Cleaning for Xcomposite-1.0.1nb3
(continues down the whole x11 tree, killed)

zembla# make clean-depends (1.14)
===> Cleaning for digest-20121220
===> Cleaning for f2c-20100903
make: "../../x11/renderproto/../../x11/renderproto/buildlink3.mk" line 12: 
Malformed conditional (${BUILTIN_X11_TYPE.native} == "XFree86")
make: "../../x11/renderproto/../../x11/renderproto/buildlink3.mk" line 12: Need 
an operator
===> Cleaning for libtool-base-2.2.6bnb8
(killed)

Reverted to 1.13 1.13 worked so somewhere in 
http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/x11/renderproto/buildlink3.mk.diff?r1=1.15&r2=1.13&f=h
 something got introduced that doesn't work.

less /etc/mk.conf
ACCEPTABLE_LICENSES+= pine-license

I assume the error occurs because the make file assumes some variable is set, 
but it's not.

>How-To-Repeat:
Update to latest pkgsrc (cvs) and have a mk.conf like what I have?
>Fix:
The work around is to revert to 1.13. The make file should probably check if 
the variable is set before trying to use it.