pkg/47652: mail/sendmail build broken by recent removal of OSI network stack

[jbernard%mines.edu@localhost]

>Number:         47652
>Category:       pkg
>Synopsis:       mail/sendmail build broken by recent removal of OSI network 
>stack
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Mar 15 23:20:00 +0000 2013
>Originator:     Jim Bernard
>Release:        NetBSD 6.99.17
>Organization:
speaking for myself
>Environment:
System: NetBSD 6.99.17: Sat Mar 9 18:52:16 MST 2013 i386
Architecture: i386
Machine: i386
>Description:
        The OSI network stack was removed a couple of weeks ago, but the
        sendmail pkg still thinks NetBSD supports it and attempts to include
        a(t least one) header file that no longer exists.  Here's where the
        build failure occurs:
...
Making all in:
/tmp/pkgsrc-work/mail/sendmail/work.nool/sendmail-8.14.6/libsmutil
Configuration: pfx=, os=NetBSD, rel=6.99.17, rbase=6, rroot=6.99, arch=i386, 
sfx=, variant=optimized
Using M4=/usr/pkg/bin/gm4
Creating 
/tmp/pkgsrc-work/mail/sendmail/work.nool/sendmail-8.14.6/obj.NetBSD.6.99.17.i386/libsmutil
 using 
/tmp/pkgsrc-work/mail/sendmail/work.nool/sendmail-8.14.6/devtools/OS/NetBSD
Including 
/tmp/pkgsrc-work/mail/sendmail/work.nool/sendmail-8.14.6/devtools/Site/site.config.m4
 
Making dependencies in 
.../mail/sendmail/work.nool/sendmail-8.14.6/obj.NetBSD.6.99.17.i386/libsmutil
cp /dev/null sm_os.h
cc -M -I. -I../../sendmail   -I../../include -DNEWDB -DNIS -DMAP_REGEX 
-DSOCKETMAP  -DNETISO -DSM_CONF_STDBOOL_H=1 -I/usr/pkg/include 
-DSMRSH_CMDDIR=\"/usr/local/libexec/sm.bin\" -DTCPWRAPPERS -DNOT_SENDMAIL  
debug.c err.c lockfile.c safefile.c snprintf.c cf.c   >> Makefile
../../sendmail/sendmail.h:97:26: fatal error: netiso/iso.h: No such file or 
directory
compilation terminated.
../../sendmail/sendmail.h:97:26: fatal error: netiso/iso.h: No such file or 
directory
compilation terminated.
../../sendmail/sendmail.h:97:26: fatal error: netiso/iso.h: No such file or 
directory
compilation terminated.
../../sendmail/sendmail.h:97:26: fatal error: netiso/iso.h: No such file or 
directory
compilation terminated.
../../sendmail/sendmail.h:97:26: fatal error: netiso/iso.h: No such file or 
directory
compilation terminated.
../../sendmail/sendmail.h:97:26: fatal error: netiso/iso.h: No such file or 
directory
compilation terminated.
*** Error code 1

Stop.
...

        Notice the presence of -DNETISO in the cc command line.

>How-To-Repeat:
        Upgrede to 6.99.17, run postinstall to remove obsolete files, which
        include /usr/include/netiso and its contents, and attempt to build
        the mail/sendmail pkg.  (I'm not sure if the change was introduced
        in 6.99.16 or 6.99.17.)

>Fix:
        patches/patch-aa patches devtools/OS/NetBSD and contains the change
-define(`confENVDEF', ` -DNETISO')
+define(`confENVDEF', ` -DNETISO -DSM_CONF_STDBOOL_H=1')
        so presumably modifying that patch to remove -DNETISO would do the
        trick, though I haven't had time to test it.