Re: pkg/47470: xulrunner don't check for sqlite3 version

[Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>]

The following reply was made to PR pkg/47470; it has been noted by GNATS.

From: Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>
To: gnats-bugs%NetBSD.org@localhost, reed%reedmedia.net@localhost
Cc: 
Subject: Re: pkg/47470: xulrunner don't check for sqlite3 version
Date: Sun, 20 Jan 2013 20:37:36 +0900 (JST)

 Hi,
 
 From: reed%reedmedia.net@localhost, Date: Sat, 19 Jan 2013 21:20:01 +0000 (UTC)
 
 >   // Ensure that we are using the same version of SQLite that we compiled 
 > with
 >   // or newer.  Our configure check ensures we are using a new enough version
 >   // at compile time.
 >   if (SQLITE_VERSION_NUMBER > ::sqlite3_libversion_number()) {
 > 
 > in ./storage/src/mozStorageService.cpp
 > 
 > Let us please patch out this check. The pkgsrc check should be good 
 > enough.  The sqlite3 check at configure time is good enough too:
 
 I feel this check is not useful practically.
 But I have negative for creating new patch to bypass runtime check.
 Because xulrunner has large amount of patches, and such patch will not
 be accepted by upstream.
 As a result, we should maintain this patch permanently.
 It is not good idea at least for me.
 
 --
 Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
 PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3