Re: pkg/47187 (net/p5-Net-LibIDN fails to build)

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/47187; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: tuxillo%dragonflybsd.org@localhost
Subject: Re: pkg/47187 (net/p5-Net-LibIDN fails to build)
Date: Mon, 24 Dec 2012 04:21:36 +0000

 On Sun, Dec 23, 2012 at 08:50:06PM +0000, David Holland wrote:
  >  Perl package contains
  >  
  >     ldflags='-Wl,-rpath,/usr/pkg/lib -fstack-protector -L/usr/pkg/lib'
  >  
  >  which is wrong since the build environment is not in and not supposed
  >  to be using /usr/pkg. This makes its way to p5-Net-LibIDN, which tries
  >  to use it to link test programs, where it's intercepted by the
  >  wrappers and removed, so the test programs' rpath ends up not being
  >  set at all so they won't run.
  >  
  >  How it gets this way I dunno.
  >  
  >  Is this (or something like it) also the problem on dfly?
 
 After discussing this with wiz we concluded that the package should
 not depend on Perl and libidn being installed in the same prefix, so
 the fact that Perl is providing the wrong library path shouldn't be
 allowed to break it.
 
 Under that assumption the following patch is a workaround; I'm
 reluctant to commit it though until we figure out what's up with the
 Perl-provided paths.
 
 Index: distinfo
 ===================================================================
 RCS file: /cvsroot/pkgsrc/net/p5-Net-LibIDN/distinfo,v
 retrieving revision 1.3
 diff -u -r1.3 distinfo
 --- distinfo   15 Sep 2010 10:32:52 -0000      1.3
 +++ distinfo   24 Dec 2012 04:18:45 -0000
 @@ -3,4 +3,4 @@
  SHA1 (Net-LibIDN-0.12.tar.gz) = ac446edf66ac523d5463b59ed9698e2ccb9b04ab
  RMD160 (Net-LibIDN-0.12.tar.gz) = a595c3758c9577b6d09d856cf220c303fdc3d2a2
  Size (Net-LibIDN-0.12.tar.gz) = 14262 bytes
 -SHA1 (patch-aa) = 2aab1ead74de84b310b5bab02c32c4993ae5a11e
 +SHA1 (patch-aa) = 71f762435abb1ba5d772f2a15655cebe124bd9b7
 Index: patches/patch-aa
 ===================================================================
 RCS file: /cvsroot/pkgsrc/net/p5-Net-LibIDN/patches/patch-aa,v
 retrieving revision 1.3
 diff -u -r1.3 patch-aa
 --- patches/patch-aa   15 Sep 2010 10:32:52 -0000      1.3
 +++ patches/patch-aa   24 Dec 2012 04:18:45 -0000
 @@ -1,8 +1,11 @@
  $NetBSD: patch-aa,v 1.3 2010/09/15 10:32:52 obache Exp $
  
 +Use both the LDFLAGS from Perl and the directory passed from the
 +pkgsrc makefile to find libidn.
 +
  --- Makefile.PL.orig  2009-02-26 12:09:45.000000000 +0000
 -+++ Makefile.PL       2009-02-28 00:05:41.000000000 +0000
 -@@ -47,15 +47,10 @@
 ++++ Makefile.PL
 +@@ -47,15 +47,12 @@ sub InitMakeParams
                "disable-tld" => \$disable_tld
        );
   
 @@ -15,8 +18,10 @@
  -             $Params{LIBS} = $Config{ldflags} . ' -lidn';
  -     }
  -
 -+     $Params{LIBS} = $Config{ldflags};
 -+     $Params{LIBS} .= " -L$libdir" if ($libdir);
 ++     $Params{LIBS} = "";
 ++     $Params{LIBS} .= "-L$libdir " if ($libdir);
 ++     $Params{LIBS} .= "-Wl,-R$libdir " if ($libdir);
 ++     $Params{LIBS} .= $Config{ldflags};
  +     $Params{LIBS} .= " -lidn";
  +     
        if ($incdir)
 
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost