Re: pkg/46190: pkgsrc-2011Q4 - misc/rlwrap - Segfaults on amd64 - odd gdb results

[Thomas Klausner <wiz%NetBSD.org@localhost>]

The following reply was made to PR pkg/46190; it has been noted by GNATS.

From: Thomas Klausner <wiz%NetBSD.org@localhost>
To: NetBSD bugtracking <gnats-bugs%NetBSD.org@localhost>
Cc: 
Subject: Re: pkg/46190: pkgsrc-2011Q4 - misc/rlwrap - Segfaults on amd64 -
 odd gdb results
Date: Mon, 10 Dec 2012 00:35:09 +0100

 --PPYy/fEw/8QCHSq3
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 On Sat, Dec 08, 2012 at 09:20:07AM +0000, Matthew Mondor wrote:
 >  I see that rlwrap was recently updated to 0.37 on -current pkgsrc.
 >  However my suggested patches weren't added, so rlwrap still segfaults
 >  on amd64 because of the lacking libutil.h include.  If that fix was
 >  applied (patch-aa), this PR could be closed.
 
 I'm a bit confused by the existing checks in rlwrap.
 
 It checks for libutil and libutil.h. In the code, it checks for
 HAVE_LIBUTIL_H, HAVE_UTIL_H (rlwrap.c) and HAVE_LIBUTIL (ptytty.c, if
 we apply the patch you suggest). AFAICS, nothing can set HAVE_UTIL_H,
 so at least that check is just wrong.
 
 Can you please confirm that the attached diff fixes the problem you
 see? (it really should check for HAVE_UTIL_H, but configure doesn't
 support this currently.)
 
 Can you please discuss the weird HAVE_UTIL_H check with upstream?
 
 Thanks,
  Thomas
 
 --PPYy/fEw/8QCHSq3
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="rlwrap.diff"
 
 Index: distinfo
 ===================================================================
 RCS file: /cvsroot/pkgsrc/misc/rlwrap/distinfo,v
 retrieving revision 1.3
 diff -u -r1.3 distinfo
 --- distinfo   30 Sep 2012 22:10:42 -0000      1.3
 +++ distinfo   9 Dec 2012 23:34:26 -0000
 @@ -3,3 +3,4 @@
  SHA1 (rlwrap-0.37.tar.gz) = c8fc5e7798a7c618a22583c56fa38d344700cc2f
  RMD160 (rlwrap-0.37.tar.gz) = 4e229e8fed579002605919760b313651aa427870
  Size (rlwrap-0.37.tar.gz) = 251438 bytes
 +SHA1 (patch-src_ptytty.c) = c76ceaf2add30ae56c8c190a8ffcb3cb79c7e1f0
 Index: patches/patch-src_ptytty.c
 ===================================================================
 RCS file: patches/patch-src_ptytty.c
 diff -N patches/patch-src_ptytty.c
 --- /dev/null  1 Jan 1970 00:00:00 -0000
 +++ patches/patch-src_ptytty.c 9 Dec 2012 23:34:26 -0000
 @@ -0,0 +1,17 @@
 +$NetBSD$
 +
 +If openpty(3) is in libutil, include util.h to avoid broken code
 +on amd64.
 +
 +--- src/ptytty.c.orig 2010-05-01 08:21:11.000000000 +0000
 ++++ src/ptytty.c
 +@@ -32,6 +32,9 @@
 + #ifdef HAVE_UNISTD_H
 + # include <unistd.h>
 + #endif
 ++#ifdef HAVE_LIBUTIL
 ++# include <util.h>
 ++#endif
 + #if defined(HAVE_STRING_H)
 + # include <string.h>
 + #endif
 
 --PPYy/fEw/8QCHSq3--