pkg/47043: security/qoauth Makefile bug revelead by cairo revbump (+FIX)

[kre%munnari.OZ.AU@localhost]

>Number:         47043
>Category:       pkg
>Synopsis:       security/qoauth Makefile bug revelead by cairo revbump (+FIX)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Oct 07 11:10:00 +0000 2012
>Originator:     Robert Elz
>Release:        NetBSD 5.1_STABLE (irrelevant)  pkgsrc current 2012-10-06
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 5.1_STABLE NetBSD 5.1_STABLE 
(JADE-1.12-20120130) #27: Tue Jan 31 05:20:31 ICT 2012 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/5/kernels/i386/JADE i386
Architecture: i386
Machine: i386
>Description:
        When the revbump caused by the cairo upgrade was applied
        to security/qoauth it revealed a bug in that package's
        Makefile (that it was cairo that caused this is irrelevant,
        any revbump would have revealed the same problem).

        As it is now, any attempt to fetch the distfile results in
        an attempt to fetch the wrong thing ...

=> Bootstrap dependency digest>=20010302: found digest-20111104
=> Fetching qoauth-1.0.1nb1-src.tar.bz2

        Note the "nb1" buried in there...

>How-To-Repeat:
        cd .../pkgsrc/security/qoauth && make checksum

        It is irrelevant whether you already have the distfile or
        not, and doing this won't alter the state of anything on
        your system - it just fails...

>Fix:
        One way is to apply the patch below.   Someone who knows
        pkgsrc better than I, and perhaps BSD Make better than I,
        may prefer doing the correction a different way.

        This patch applies in pkgsrc/security/qoauth

--- Makefile    2012-10-07 17:55:44.000000000 +0700
+++ Makefile.fixed      2012-10-07 17:55:13.000000000 +0700
@@ -1,8 +1,8 @@
 # $NetBSD: Makefile,v 1.2 2012/10/02 17:11:55 tron Exp $
 #
 
-PKGNAME=       qoauth-1.0.1
-DISTNAME=      ${PKGNAME}-src
+DISTNAME=qoauth-1.0.1-src
+PKGNAME=${DISTNAME:S/-src//}
 PKGREVISION=   1
 CATEGORIES=    security
 MASTER_SITES=  http://files.ayoy.net/qoauth/release/1.0.1/src/