pkg/47017: mk/jpeg.bl3.mk is order-dependent

[dholland%netbsd.org@localhost]

>Number:         47017
>Category:       pkg
>Synopsis:       mk/jpeg.bl3.mk is order-dependent
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Sep 29 22:45:00 +0000 2012
>Originator:     David A. Holland
>Release:        pkgsrc of 20120929
>Organization:
>Environment:
n/a
>Description:

If you include ../../mk/jpeg.buildlink3.mk in your package and it
happens to be after some other package you're using has included it in
its own bl3, you don't get a direct dependence on the jpeg library.

>How-To-Repeat:

Do 'make show-depends' in games/flightgear, examine the results and
the makefile.

>Fix:

The problem is that mk/jpeg.bl3.mk is multiple-include-protected, so
the jpeg library's own bl3 is not included except the first time
through. Moving the jpeg library bl3 inclusions outside the include
protection will fix the problem... but may cause other problems, so
I'd like a second opinion before just fixing it myself.