Re: pkg/46570 (infelicities in pkglint)

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/46570; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/46570 (infelicities in pkglint)
Date: Sun, 9 Sep 2012 20:56:13 +0000

 (two mails here, that were accidentally sent to gnats instead of gnats-bugs)
 
    ------
 
 From: diro%nixsyspaus.org@localhost
 To: gnats%NetBSD.org@localhost
 Subject: Re: pkg/46570 (infelicities in pkglint)
 Date: Wed, 5 Sep 2012 17:34:51 -0400
 
 Thanks, wiz, for the fixes. Just some more comments and infelicities:
 
 >> 2) It did not throw an error on this line:
 >>  
 >>  ${EGDIR/apparmor.d ${EGDIR/dbus-1/system.d ${EGDIR/pam.d
 > >  
 > >  Non-closed braces need to throw an error.
 
 > It can't be a complete Makefile parser, and even make(1) doesn't complain 
 > about
 > FOO= ${EGDIR/apparmor.d ${EGDIR/dbus-1/system.d ${EGDIR/pam.d
 >
 > I see this as WONTFIX.
 
 
 That seems reasonable. However, bmake _is_ a complete Makefile parser. Doesn't
 our make at least need to complain about this (I know it's not realistic to
 expect all the *make programs to fix this)?
 
 
 > I've just fixed these issues. USE_GAMESGROUP wasn't even documented in
 > the guide, so I fixed that as well.
 
 
 I would like to note that there are also many other things which are part of
 the pkgsrc framework that are not documented in the guide. It makes it more
 difficult for people like me, who jump in every few months, to track the 
changes
 in pkgsrc and to not resort to bothering #pkgsrc for answers if greping
 Makefiles in wip/ fails.
 
 Not meaning to turn this into a general complaint ticket about pkgsrc;
 however, since we've noticed that some things are not documented, could
 anything brought up in this thread, which is not documented already, be 
documented after discussion?
 
 >> 5) pkglint needs to not complain about empty PLISTs for pear packages and
 >>  other packages in which the PLIST is handled automagically.
 
 >It doesn't, AFAIK.
 > # cd /usr/pkgsrc/www/pear-HTTP
 > # pkglint 
 > ERROR: Makefile: All packages must define their LICENSE.
 > WARN: Makefile:6: "brook%nmsu.edu@localhost 
 > pkgsrc-users%NetBSD.org@localhost" is not a valid
 > mail address.
 > 1 errors and 1 warnings found. (Use -e for more details.)
 > # ls
 > CVS      DESCR    Makefile distinfo
 
 Ahh, but it does:
 
 # cd pkgsrc/wip/pear-HTTP_Client/
 # pkglint
 ERROR: ../../lang/php/pear.mk:69: Cannot read ./../../lang/php5/buildlink3.mk.
 WARN: PLIST:1: PLIST files shouldn't be empty.
 1 errors and 1 warnings found.
 
 Is is now preferred to not have any PLIST file for pear packages instead of
 an empty one?
 
 and:
 
 6) Like the previous behaviour with FETCH_USING (now fixed), it doesn't
 recognize RUN_LDCONFIG:
 
 WARN: Makefile:25: RUN_LDCONFIG is defined but not used. Spelling mistake?
 0 errors and 1 warnings found.
 
 
 From: diro%nixsyspaus.org@localhost
 To: gnats%NetBSD.org@localhost
 Subject: Re: pkg/46570 (infelicities in pkglint)
 Date: Fri, 7 Sep 2012 14:31:37 -0400
 
 7) pkglint doesn't understand KDE_LANGUAGE, even though it's defined in the
 various buildlink3.mk files that are connected to the package
 (x11/kde4-l10n-de, for example).
 
 # pkglint
 WARN: Makefile:3: KDE_LANGUAGE is defined but not used. Spelling mistake?
 0 errors and 1 warnings found.
 
 This may be getting too package specific, though, and not pkgsrc
 framework-specific.