pkg/46825: bootstrap fails on Solaris 10

[joern.clausen%uni-bielefeld.de@localhost]

>Number:         46825
>Category:       pkg
>Synopsis:       bootstrap fails on Solaris 10
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Aug 22 15:10:01 +0000 2012
>Originator:     Jörn Clausen
>Release:        
>Organization:
University of Bielefeld
>Environment:
>Description:
bootstrap fails on Solaris 10 and standalone GCC 4.7.0 while building libfetch 
for pkg_install:

gcc -O -I/usr/sfw/include  -Wall -Wstrict-prototypes -Wmissing-prototypes 
-Wno-uninitialized -Wreturn-type -Wpointer-arith -Wcast-qual -Wwrite-strings 
-Wswitch -Wshadow -Werror  -D_LARGEFILE_SOURCE -D_LARGE_FILES 
-D_FILE_OFFSET_BITS=64 -DDEF_UMASK=022 
-I/pkgsrc/source/pkgsrc/bootstrap/work.pkgsrc-i86/wrk/pkgtools/pkg_install/work/libarchive/libarchive
 
-I/pkgsrc/source/pkgsrc/bootstrap/work.pkgsrc-i86/wrk/pkgtools/pkg_install/work/libfetch
 -DHAVE_NBCOMPAT_H=1 
-I/pkgsrc/source/pkgsrc/bootstrap/work.pkgsrc-i86/wrk/pkgtools/pkg_install/work/libnbcompat
 -I/usr/sfw/include -I. -D_LARGEFILE_SOURCE -D_LARGE_FILES -DINET6 -DWITH_SSL 
-DFTP_COMBINE_CWDS -c common.c
In file included from /usr/sfw/include/openssl/ui_compat.h:63:0,
                 from /usr/sfw/include/openssl/des_old.h:439,
                 from /usr/sfw/include/openssl/des.h:101,
                 from /usr/sfw/include/openssl/evp.h:93,
                 from /usr/sfw/include/openssl/x509.h:67,
                 from common.h:42,
                 from common.c:70:
/usr/sfw/include/openssl/ui.h:220:1: error: function declaration isn't a 
prototype [-Werror=strict-prototypes]
In file included from /usr/sfw/include/openssl/rsa.h:62:0,
                 from /usr/sfw/include/openssl/evp.h:137,
                 from /usr/sfw/include/openssl/x509.h:67,
                 from common.h:42,
                 from common.c:70:
/usr/sfw/include/openssl/asn1.h:478:2: error: function declaration isn't a 
prototype [-Werror=strict-prototypes]
/usr/sfw/include/openssl/asn1.h:479:2: error: function declaration isn't a 
prototype [-Werror=strict-prototypes]
/usr/sfw/include/openssl/asn1.h:480:2: error: function declaration isn't a 
prototype [-Werror=strict-prototypes]
/usr/sfw/include/openssl/asn1.h:481:2: error: function declaration isn't a 
prototype [-Werror=strict-prototypes]
/usr/sfw/include/openssl/asn1.h:800:4: error: function declaration isn't a 
prototype [-Werror=strict-prototypes]
/usr/sfw/include/openssl/asn1.h:802:4: error: function declaration isn't a 
prototype [-Werror=strict-prototypes]
...

After removing "-Wstrict-prototypes" from 
pkgtools/bootstrap-mk-files/files/mods/SunOS.bsd.sys.mk, hitting another error, 
trying to fix it again, hitting yet another error, I finally made this change:

--- SunOS.bsd.sys.mk    2012/08/22 14:50:02     1.1
+++ SunOS.bsd.sys.mk    2012/08/22 14:50:13
@@ -26,10 +26,10 @@
 .endif
 .endif
 
-.if !defined(NOGCCERROR)
-CFLAGS+= -Werror
-.endif
-CFLAGS+= ${CWARNFLAGS}
+#.if !defined(NOGCCERROR)
+#CFLAGS+= -Werror
+#.endif
+#CFLAGS+= ${CWARNFLAGS}
 
 .if defined(DESTDIR)
 CPPFLAGS+= -nostdinc -idirafter ${DESTDIR}/usr/include

I'm not sure where NOGCCERROR is meant to be defined, especially during 
bootstrap.

And for the record: I'd like to repeat my discontent that I am forced to use 
/usr/sfw in my pkgsrc installation. I'd rather bootstrap without SSL support 
and rebuild the package later using security/openssl.
>How-To-Repeat:

>Fix: