Re: pkg/46778: graphics/p5-GD needs libiconv

[Jörn Clausen <joern.clausen%uni-bielefeld.de@localhost>]

The following reply was made to PR pkg/46778; it has been noted by GNATS.

From: =?ISO-8859-1?Q?J=F6rn_Clausen?= <joern.clausen%uni-bielefeld.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: OBATA Akio <obache%NetBSD.org@localhost>, 
solaris-pkg-people%NetBSD.org@localhost,
 gnats-admin%NetBSD.org@localhost, pkgsrc-bugs%NetBSD.org@localhost
Subject: Re: pkg/46778: graphics/p5-GD needs libiconv
Date: Wed, 08 Aug 2012 14:12:52 +0200

 >   Is it possible to remove "workaround for solarsi systems?" from 
 > Makefile.PL?
 
 Good question. I don't see any trace of iconv usage, neither in 
 graphics/p5-GD nor in graphics/gd or any of the dependencies. After 
 removing this "workaround", the package still compiles - and fails with 
 and without iconv in the same way on "bmake test"...
 
 So instead of adding a dependency, I suggest this patch:
 
 --- Makefile.PL 2012/08/08 11:57:50     1.1
 +++ Makefile.PL 2012/08/08 11:58:00
 @@ -134,11 +134,6 @@
     @LIBS    = qw(-llibgd.olb -llibpng.olb -llibz.olb);
   }
 
 -# workaround for solaris systems?
 -elsif ($^O =~ /solaris/i) {
 -    push @LIBS,'-liconv';
 -}
 -
   ###################################################################
   # path to libgd, skip prompt if passed in from above
   ###################################################################
 
 -- 
   Jörn Clausen                             
joern.clausen%uni-bielefeld.de@localhost
   Hochschulrechenzentrum                 http://www.uni-bielefeld.de/hrz/
   Universität Bielefeld