pkg/46720: devel/glib2 configure fails on Darwin

[jwbacon%tds.net@localhost]

>Number:         46720
>Category:       pkg
>Synopsis:       devel/glib2 configure fails on Darwin
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jul 18 21:05:00 +0000 2012
>Originator:     Jason Bacon
>Release:        Not a NetBSD issue
>Organization:
Acadix Consulting, LLC
>Environment:
Darwin heron 10.8.0 Darwin Kernel Version 10.8.0: Tue Jun  7 16:33:36 PDT 2011; 
root:xnu-1504.15.3~1/RELEASE_I386 i386
>Description:
glib2 fails to configure on Darwin due to iconv_open() tests.

I traced the problem to a fix intended for Darwin in hacks.mk.  I believe it is 
assuming the use of a native libiconv(), and changes libiconv_open() calls to 
iconv_open() to accomodate the OS X libiconv.

This is not necessary on Snow Leopard, which has both iconv_open() and 
libiconv_open():

Darwin heron bacon ~/Pkgsrc/pkgsrc-1/jb-wip/glib2 453: nm 
/usr/lib/libiconv.2.dylib  | grep open
         U _fopen$UNIX2003
00015049 T _iconv_open
00015860 T _libiconv_open

It may be necessary on older Darwin platforms.

It is detrimental when using the pkgsrc libiconv, which lacks iconv_open():

Darwin heron bacon ~/Pkgsrc/pkgsrc-1/jb-wip/glib2 454: nm 
~/Pkgsrc/pkg-1/lib/libiconv.a  | grep open
00014560 T _libiconv_open
00013cb0 T _libiconv_open_into

My mk.conf:

# Example /Users/bacon/Pkgsrc/sys-1/etc/mk.conf file produced by 
bootstrap-pkgsrc
# Wed May 16 15:19:26 CDT 2012

.ifdef BSD_PKG_MK       # begin pkgsrc settings


UNPRIVILEGED=           yes
PKG_DBDIR=              /Users/bacon/Pkgsrc/sys-1/var/db/pkg
LOCALBASE=              /Users/bacon/Pkgsrc/pkg-1
VARBASE=                /Users/bacon/Pkgsrc/sys-1/var
PKG_SYSCONFBASE=        /Users/bacon/Pkgsrc/sys-1/etc
PKG_TOOLS_BIN=          /Users/bacon/Pkgsrc/pkg-1/sbin
PKGMANDIR=              man


.endif                  # end pkgsrc settings

X11_TYPE=               modular
FETCH_USING?=           fetch
PREFER_NATIVE=          no
PREFER_PKGSRC=          yes
ALLOW_VULNERABLE_PACKAGES=      yes
ACCEPTABLE_LICENSES+=   openmotif-license
ACCEPTABLE_LICENSES+=   qpl-v1.0
ACCEPTABLE_LICENSES+=   phylip-license
ACCEPTABLE_LICENSES+=   eclipse-license

>How-To-Repeat:

Try building glib2 on Darwin with the above mk.conf.
>Fix:

I think the following change to hacks.mk is correct, but I could be wrong:

from:

.if ${OPSYS} == "Darwin"

to:

.if ${OPSYS} == "Darwin" && ${PREFER_NATIVE} == "yes"