pkgsrc-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/46662: [PATCH] upgrade timidity port to 2.14.0

The following reply was made to PR pkg/46662; it has been noted by GNATS.

From: "Yair K." <cesium2%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/46662: [PATCH] upgrade timidity port to 2.14.0
Date: Sat, 7 Jul 2012 14:34:30 +0300

 --Boundary-01=_G7B+Pa/AItCqbzg
 Content-Type: text/plain;
   charset="iso-8859-15"
 Content-Transfer-Encoding: 7bit
 
 I recall that if X11_TYPE is native, pkgsrc will not fetch libXaw and its 
 deps. It is possible that someone has X11_TYPE == native, XAW_TYPE not set 
 (i.e. == standard), libxaw3d (etc.) installed but not libxaw. In that case, 
 the port attached in the report would fail to find xaw and will not check for 
 Xaw3d - which is perhaps not what the user desired...
 
  I think the best solution would be to let the configure script search for the 
 other libs in this case, so long as they're after Xaw in the search order. The 
 diff below should fix this:
 
 --- ./options.mk       2012-07-06 00:40:09.000000000 +0300
 +++ ./options.mk       2012-07-07 14:15:55.681307814 +0300
 @@ -14,9 +14,9 @@
  .include "../../graphics/png/buildlink3.mk"
  
  .if !defined(XAW_TYPE)
 -WITH_XAWLIB=--with-xawlib=xaw
 +WITH_XAWLIB=--with-xawlib=xaw,xaw3d,neXtaw
  .elif ${XAW_TYPE} == "standard"
 -WITH_XAWLIB=--with-xawlib=xaw
 +WITH_XAWLIB=--with-xawlib=xaw,xaw3d,neXtaw
  .elif ${XAW_TYPE} == "3d"
  WITH_XAWLIB=--with-xawlib=xaw3d
  .elif ${XAW_TYPE} == "xpm"
 
 --Boundary-01=_G7B+Pa/AItCqbzg
 Content-Type: text/html;
   charset="iso-8859-15"
 Content-Transfer-Encoding: 7bit
 
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" 
"http://www.w3.org/TR/REC-html40/strict.dtd";>
 <html><head><meta name="qrichtext" content="1" /><style type="text/css">
 p, li { white-space: pre-wrap; }
 </style></head><body style=" font-family:'DejaVu Sans Mono'; font-size:16pt; 
font-weight:400; font-style:normal;">
 <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; 
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">I 
recall that if X11_TYPE is native, pkgsrc will not fetch libXaw and its deps. 
It is possible that someone has X11_TYPE == native, XAW_TYPE not set (i.e. == 
standard), libxaw3d (etc.) installed but not libxaw. In that case, the port 
attached in the report would fail to find xaw and will not check for Xaw3d - 
which is perhaps not what the user desired...</p>
 <p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; 
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; 
">&nbsp;</p>
 <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; 
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"> I 
think the best solution would be to let the configure script search for the 
other libs in this case, so long as they're after Xaw in the search order. The 
diff below should fix this:</p>
 <p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; 
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; 
">&nbsp;</p>
 <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; 
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">--- 
./options.mk      2012-07-06 00:40:09.000000000 +0300</p>
 <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; 
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">+++ 
./options.mk      2012-07-07 14:15:55.681307814 +0300</p>
 <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; 
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">@@ 
-14,9 +14,9 @@</p>
 <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; 
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"> 
.include &quot;../../graphics/png/buildlink3.mk&quot;</p>
 <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; 
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"> </p>
 <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; 
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"> .if 
!defined(XAW_TYPE)</p>
 <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; 
margin-right:0px; -qt-block-indent:0; text-indent:0px; 
-qt-user-state:0;">-WITH_XAWLIB=--with-xawlib=xaw</p>
 <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; 
margin-right:0px; -qt-block-indent:0; text-indent:0px; 
-qt-user-state:0;">+WITH_XAWLIB=--with-xawlib=xaw,xaw3d,neXtaw</p>
 <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; 
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"> 
.elif ${XAW_TYPE} == &quot;standard&quot;</p>
 <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; 
margin-right:0px; -qt-block-indent:0; text-indent:0px; 
-qt-user-state:0;">-WITH_XAWLIB=--with-xawlib=xaw</p>
 <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; 
margin-right:0px; -qt-block-indent:0; text-indent:0px; 
-qt-user-state:0;">+WITH_XAWLIB=--with-xawlib=xaw,xaw3d,neXtaw</p>
 <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; 
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"> 
.elif ${XAW_TYPE} == &quot;3d&quot;</p>
 <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; 
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"> 
WITH_XAWLIB=--with-xawlib=xaw3d</p>
 <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; 
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"> 
.elif ${XAW_TYPE} == &quot;xpm&quot;</p>
 <p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; 
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; 
">&nbsp;</p></body></html>
 --Boundary-01=_G7B+Pa/AItCqbzg--
Home | Main Index | Thread Index | Old Index