Re: pkg/46639: irssi port disables ncurses on non-NetBSD platforms

[Matthew Mondor <mm_lists%pulsar-zone.net@localhost>]

The following reply was made to PR pkg/46639; it has been noted by GNATS.

From: Matthew Mondor <mm_lists%pulsar-zone.net@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/46639: irssi port disables ncurses on non-NetBSD platforms
Date: Fri, 29 Jun 2012 21:12:04 -0400

 --MP_/80+c4nXVj8CC.K8GBHrR/l=
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 
 > The irssi port's Makefile adds "--without-ncurses" to CONFIGURE_ARGS, which 
 > breaks compilation on non-NetBSD platforms which use ncurses.
 
 It seems that the buildlink include is missing.
 
 Possibly that like mutt does, the irssi package should isolate as
 options the various backends supported, and require that at least one be
 selected?
 
 $ cd /usr/pkgsrc/mail/mutt/
 $ make show-options
 [...]
 Exactly one of the following display options is required:
         curses   Enable curses support.
         ncurses  Enable ncurses support.
         ncursesw         Enable wide character ncurses support.
         slang    Enable S-Lang support.
 
 Example diff attached (untested, and sorry for not providing it against
 -current pkgsrc, but it should give an idea)
 -- 
 Matt
 
 --MP_/80+c4nXVj8CC.K8GBHrR/l=
 Content-Type: text/plain
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment; filename=irssi-diff.txt
 
 Index: Makefile
 ===================================================================
 RCS file: /data/rsync/netbsd-cvs/pkgsrc/chat/irssi/Makefile,v
 retrieving revision 1.56
 diff -u -p -r1.56 Makefile
 --- Makefile   22 Apr 2011 13:43:06 -0000      1.56
 +++ Makefile   30 Jun 2012 01:07:40 -0000
 @@ -20,9 +20,7 @@ GNU_CONFIGURE=               yes
  USE_LIBTOOL=          yes
  USE_TOOLS+=           pkg-config
  
 -CONFIGURE_ARGS+=      --with-terminfo \
 -                      --with-proxy \
 -                      --without-ncurses \
 +CONFIGURE_ARGS+=      --with-proxy \
                        --sysconfdir=${PKG_SYSCONFDIR}
  
  EGDIR=                ${PREFIX}/share/examples/irssi
 Index: options.mk
 ===================================================================
 RCS file: /data/rsync/netbsd-cvs/pkgsrc/chat/irssi/options.mk,v
 retrieving revision 1.10
 diff -u -p -r1.10 options.mk
 --- options.mk 6 Mar 2011 04:12:09 -0000       1.10
 +++ options.mk 30 Jun 2012 01:07:09 -0000
 @@ -1,12 +1,28 @@
  # $NetBSD: options.mk,v 1.10 2011/03/06 04:12:09 dholland Exp $
  
  PKG_OPTIONS_VAR=      PKG_OPTIONS.irssi
 +PKG_OPTIONS_REQUIRED_GROUPS= display
 +PKG_OPTIONS_GROUP.display= terminfo ncurses
  PKG_SUPPORTED_OPTIONS=        inet6 perl ssl
  PKG_SUGGESTED_OPTIONS=        inet6
  PKG_OPTIONS_LEGACY_OPTS+=     irssi-perl:perl
 +.if ${OPSYS} == "NetBSD"
 +PKG_SUGGESTED_OPTIONS+= terminfo
 +.else
 +PKG_SUGGESTED_OPTIONS+= ncurses
 +.endif
  
  .include "../../mk/bsd.options.mk"
  
 +.if !empty(PKG_OPTIONS:Mterminfo)
 +CONFIGURE_ARGS+=      --with-terminfo --without-ncurses
 +.endif
 +
 +.if !empty(PKG_OPTIONS:Mncurses)
 +.include "../../devel/ncurses/buildlink3.mk"
 +CONFIGURE_ARGS+=      --without-terminfo --with-ncurses
 +.endif
 +
  .if !empty(PKG_OPTIONS:Mperl)
  USE_TOOLS+=           perl:run
  PERL5_PACKLIST=               auto/Irssi/.packlist
 
 --MP_/80+c4nXVj8CC.K8GBHrR/l=--