pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

pkg/46603: Update request for time/xtu to version 1.3 (patch included)



>Number:         46603
>Category:       pkg
>Synopsis:       Update request for time/xtu to version 1.3 (patch included)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Fri Jun 15 13:45:00 +0000 2012
>Originator:     Robert Elz
>Release:        NetBSD 5.0 (any) pkgsrc current as of 2012-06-15
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 5.1_STABLE NetBSD 5.1_STABLE 
(JADE-1.12-20120130) #27: Tue Jan 31 05:20:31 ICT 2012 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/5/kernels/i386/JADE i386
Architecture: i386
Machine: i386
>Description:
        The distfile for time/xtu is no longer available where
        pkgsrc/time/xtu expects to find it.

        At its new location (it is amazing what google can find...)
        the current version is 1.3 (pkgsrc has 1.2)

        The sole difference between 1.2 & 1.3 (aside from a few minor
        address updates) is the addition of a man page (and mention
        of it in the README file).

>How-To-Repeat:
        Attempt to fetch the distfile for time/xtu using pkgsrc.
        Watch it fail... (the old site is one that doesn't return
        an error, it returns a meaningless "not here" (in German)
        page instead, so you'll see checksum errors).

>Fix:
        Apply the patch appended.  That will update xtu to 1.3,
        and cause the man page to be installed.

        Note: operationally this is essentially identical to what
        pkgsrc had before, except that now it has a man page, and
        is actually able to fetch and build from an existing distfile.
        (I actually also turned on use of XPM for images - the program
        assumed that either that, or Imlib, would generally be used,
        pkgsrc has been using neither ... expect some compiler warnings,
        fixes for those are easy (just added casts) if you care).

        Ideally someone who understands pkgsrc and options.mk should
        implement the Imlib option, as a build time option for xtu.
        That won't be me!

        However, this version (well, both versions) have bugs, I have
        observed xtu stopping display updates, and instead vanishing
        off into an infinite loop.  I think that's caused by processing
        time using SIGALRM, and then descending into the internals of
        X directly from the signal handler (truly, not a good idea.)
        I have a rewrite that fixes that (I think) that I'll be sending
        to the program's author (so there might be a 1.4 sometime soon),
        however there is another bug that I'm still attempting to
        track down (not yet sure if it is caused by my modifications or
        if it was always there), and I want to get that fixed, or at
        least understood, first (the shape exension, if turned on, with
        the second hand enabled, causes the second hand to appear only
        every second second... - that's in my modified version anyway).

        Apply this patch in pkgsrc/time/xtu

Index: Makefile
===================================================================
RCS file: /cvsroot/NetBSD/pkgsrc/time/xtu/Makefile,v
retrieving revision 1.10
diff -u -r1.10 Makefile
--- Makefile    28 Nov 2011 00:06:18 -0000      1.10
+++ Makefile    15 Jun 2012 13:18:48 -0000
@@ -1,13 +1,12 @@
 # $NetBSD: Makefile,v 1.10 2011/11/28 00:06:18 wiz Exp $
 #
 
-DISTNAME=      xtu-1.2
-PKGREVISION=   1
+DISTNAME=      xtu-1.3
 CATEGORIES=    time
-MASTER_SITES=  http://core.de/~coto/projects/xtu/
+MASTER_SITES=  http://coto.marsrakete.de/projects/xtu/
 
 MAINTAINER=    pkgsrc-users%NetBSD.org@localhost
-HOMEPAGE=      http://core.de/~coto/projects/xtu/
+HOMEPAGE=      http://coto.marsrakete.de/projects/xtu/
 COMMENT=       Small configurable X11 analog clock
 
 PKG_DESTDIR_SUPPORT=   user-destdir
@@ -15,12 +14,14 @@
 INSTALLATION_DIRS=     bin
 
 do-build:
-       cd ${WRKSRC} && ${CC} *.c -o xtu -I${X11BASE}/include ${X11_LDFLAGS} 
-lX11 -lXext
+       cd ${WRKSRC} && ${CC} -DUSE_XPM *.c -o xtu -I${X11BASE}/include 
${X11_LDFLAGS} -lXpm -lX11 -lXext
 
 do-install:
        ${INSTALL_PROGRAM} ${WRKSRC}/xtu ${DESTDIR}${PREFIX}/bin/
+       ${INSTALL_MAN} ${WRKSRC}/xtu.1 ${DESTDIR}${PREFIX}/man/man1
 
 .include "../../x11/libX11/buildlink3.mk"
 .include "../../x11/libXext/buildlink3.mk"
+.include "../../x11/libXpm/buildlink3.mk"
 .include "../../x11/xextproto/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
Index: PLIST
===================================================================
RCS file: /cvsroot/NetBSD/pkgsrc/time/xtu/PLIST,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 PLIST
--- PLIST       27 Feb 2002 21:24:58 -0000      1.1.1.1
+++ PLIST       15 Jun 2012 13:19:08 -0000
@@ -1,2 +1,3 @@
 @comment $NetBSD: PLIST,v 1.1.1.1 2002/02/27 21:24:58 agc Exp $
 bin/xtu
+man/man1/xtu.1
Index: distinfo
===================================================================
RCS file: /cvsroot/NetBSD/pkgsrc/time/xtu/distinfo,v
retrieving revision 1.3
diff -u -r1.3 distinfo
--- distinfo    23 Feb 2005 19:14:56 -0000      1.3
+++ distinfo    15 Jun 2012 13:19:15 -0000
@@ -1,5 +1,5 @@
 $NetBSD: distinfo,v 1.3 2005/02/23 19:14:56 wiz Exp $
 
-SHA1 (xtu-1.2.tar.gz) = 1adb8938917c7f3c140431607a0f1b8843186fe2
-RMD160 (xtu-1.2.tar.gz) = 30c481988ab62e4214cb8b1ab1ff684bc52a95f7
-Size (xtu-1.2.tar.gz) = 20128 bytes
+SHA1 (xtu-1.3.tar.gz) = f7765d9e7afe7a140ce1e6bb50a2e635d29dcfe9
+RMD160 (xtu-1.3.tar.gz) = a810535acfed006caf7ad138a9612468027bc837
+Size (xtu-1.3.tar.gz) = 21980 bytes



Home | Main Index | Thread Index | Old Index