Re: pkg/46519: [Patch]sysutils/ups-nut: a security patch for CVE-2012-2944

2012/6/3 OBATA Akio <obache%netbsd.org@localhost>

The following reply was made to PR pkg/46519; it has been noted by GNATS.

From: "OBATA Akio" <obache%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc:
Subject: Re: pkg/46519: [Patch]sysutils/ups-nut: a security patch for
CVE-2012-2944
Date: Sun, 03 Jun 2012 21:48:06 +0900

On Sun, 03 Jun 2012 00:20:01 +0900, <wenheping%gmail.com@localhost> wrote:

> Index: Makefile.common
> ===================================================================
> RCS file: /cvsroot/pkgsrc/sysutils/ups-nut/Makefile.common,v
> retrieving revision 1.3
> diff -u -p -r1.3 Makefile.common
> --- Makefile.common 29 Jul 2011 15:11:40 -0000 1.3
> +++ Makefile.common 2 Jun 2012 15:09:46 -0000
> @@ -6,6 +6,7 @@
> # used by sysutils/p5-ups-nut/Makefile
> DISTNAME= nut-2.6.1
> +PKGREVISION= 1
> CATEGORIES= sysutils
> MASTER_SITES= http://www.networkupstools.org/source/2.6/

Please not put PKGREVISION in Makefile.common.
It may be bumped separately for each sub packages.

> RCS file: patches/patch-ad
> diff -N patches/patch-ad
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ patches/patch-ad 2 Jun 2012 15:09:46 -0000

Please use new patch name scheme (patch-common_parseconf.c).

For PKGREVISION, patched files is common file, I don't know which sub
packages are using the code.
How about simply update to 2.6.4, it contains the fix?

Update to 2.6.4 is a better way but it need more work.

I would try it later.

wen

--
OBATA Akio / obache%NetBSD.org@localhost