pkg/46333: qmail-lspawn and qmail-rspawn segfault in 64bit Dragonfly

[neil%athlon2.akihabara.co.uk@localhost]

>Number:         46333
>Category:       pkg
>Synopsis:       qmail-lspawn and qmail-rspawn segfault in 64bit Dragonfly
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Apr 14 13:50:00 +0000 2012
>Originator:     Neil Booth
>Release:        DragonFly 3.1-DEVELOPMENT
>Organization:
None
>Environment:
System: DragonFly athlon2.akihabara.co.uk 3.1-DEVELOPMENT DragonFly 
v3.1.0.357.g753df-DEVELOPMENT #1: Thu Mar 22 07:59:02 JST 2012 
root%athlon2.akihabara.co.uk@localhost:/usr/obj/usr/src/sys/X86_64_GENERIC 
x86_64


>Description:
        qmail-send fails to start:

Apr 14 20:07:35 athlon2 kernel: pid 96583 (qmail-rspawn), uid 1007: exited on 
signal 11
Apr 14 20:07:36 athlon2 kernel: pid 96587 (qmail-lspawn), uid 0: exited on 
signal 11 (core dumped)
Apr 14 20:07:36 athlon2 kernel: pid 96588 (qmail-rspawn), uid 1007: exited on 
signal 11
Apr 14 20:07:37 athlon2 kernel: pid 96592 (qmail-lspawn), uid 0: exited on 
signal 11 (core dumped)

>How-To-Repeat:
        start up qmail-send
>Fix:

The issue is qmail's rampant abuse of prototypes.  Fixed below.

diff --git a/mail/qmail/distinfo b/mail/qmail/distinfo
index ce7d561..b99d8cb 100644
--- a/mail/qmail/distinfo
+++ b/mail/qmail/distinfo
@@ -33,3 +33,4 @@ Size (qmail-smtpd-viruscan-logging.patch) = 2157 bytes
 SHA1 (patch-aa) = 2c8c50889cbc7da8c51bf6d44c0b31f5f0853896
 SHA1 (patch-ab) = 15e6466c655058664cb660e5e12232bf45010814
 SHA1 (patch-hier.c) = 3c3b6c9404ea2a852b89481dc67bf4ae4d869570
+SHA1 (patch-spawn.c) = 8459ddb4aac3ee7c9f5324fd110e744f06f6b5fb
diff --git a/mail/qmail/patches/patch-spawn.c b/mail/qmail/patches/patch-spawn.c
new file mode 100644
index 0000000..cf71121
--- /dev/null
+++ b/mail/qmail/patches/patch-spawn.c
@@ -0,0 +1,11 @@
+$NetBSD$
+
+--- spawn.c.orig       2012-04-14 13:35:08.381341000 +0000
++++ spawn.c
+@@ -1,5 +1,6 @@
+ #include <sys/types.h>
+ #include <sys/stat.h>
++#include "alloc.h"
+ #include "sig.h"
+ #include "wait.h"
+ #include "substdio.h"