pkg/46289: sysutils/cdrtools depends on libiconv

[joern.clausen%uni-bielefeld.de@localhost]

>Number:         46289
>Category:       pkg
>Synopsis:       sysutils/cdrtools depends on libiconv
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Apr 03 14:40:03 +0000 2012
>Originator:     Jörn Clausen
>Release:        
>Organization:
University of Bielefeld
>Environment:
>Description:
sysutils/cdrtools contains a dependency on libiconv:

        ==> LINKING "OBJ/i386-sunos5-gcc/mkisofs"
Undefined                       first referenced
 symbol                             in file
libiconv_close                      
../libs/i386-sunos5-gcc/libsiconv.a(sic_nls.o)
libiconv_open                       
../libs/i386-sunos5-gcc/libsiconv.a(sic_nls.o)
libiconv                            OBJ/i386-sunos5-gcc/joliet.o
ld: fatal: Symbol referencing errors. No output written to 
OBJ/i386-sunos5-gcc/mkisofs

Why did this go unnoticed? I received this error when compiling my packages on 
Solaris 10 with a stand-alone GCC 4.7.0 (with enhanced rpath handling). My 
binaries created with lang/gcc34 also use this library:

$ ldd /usr/pkgsrc/20110926/bin/mkisofs
[...]
        libiconv.so.2 =>         /usr/pkgsrc/20110926/lib/libiconv.so.2
[...]

but didn't mind the missing dependency during build.
>How-To-Repeat:

>Fix:
--- Makefile    2012/04/03 14:14:19     1.1
+++ Makefile    2012/04/03 14:21:36
@@ -140,5 +140,6 @@
        ${INSTALL_DATA} ${WRKSRC}/cdrecord/cdrecord.dfl \
                ${DESTDIR}${PREFIX}/share/examples/cdrtools/cdrecord
 
+.include "../../converters/libiconv/buildlink3.mk"
 .include "../../mk/oss.buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"