Re: PR/45826 CVS commit: pkgsrc/devel/bison

["OBATA Akio" <obache%netbsd.org@localhost>]

The following reply was made to PR pkg/45826; it has been noted by GNATS.

From: "OBATA Akio" <obache%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: PR/45826 CVS commit: pkgsrc/devel/bison
Date: Sat, 14 Jan 2012 14:31:52 +0900

 On Sat, 14 Jan 2012 02:15:05 +0900, Daniel Horecki <morr%netbsd.org@localhost> 
wrote:
 
 >  Module Name:        pkgsrc
 >  Committed By:       morr
 >  Date:               Fri Jan 13 17:13:39 UTC 2012
 > Modified Files:
 >      pkgsrc/devel/bison: Makefile
 > Log Message:
 >  Add missing converters/libiconv buildlink, fixes PR 45826.
 > Bump PKGREVISION
 
 I'm not sure this is the real fix.
 
 devel/bison already buildlink with devel/gettext-lib, and it will pull 
converters/libiconv.
 
 If builtin gettext-lib is used, builtin libiconv must be used
 (You can see it in in devel/gettext-lib/buildlink3.mk).
 
 If USE_GNU_ICONV=Yes, it force to use GNU iconv from pkgsrc must be used
 (You can see it in converters/libiconv/builtin.mk).
 
 After your change, it result in mixed usage of builtin libiconv through 
gettext-lib and
 pkgsrc GNU libiconv, it is not good situation.
 
 About this PR, USE_GNU_ICONV is not a user settable variable, so it must not 
be set by users.
 PREFER_PKGSRC+=libiconv should be used instead.
 
 Anyway, this is a general issue for current {buildlink,builtin}.mk, for 
following situation:
   * package A depend on package B
   * both A and B have builtin support
   * builtin one is preferred for A and pkgsrc one is preferred for B.
 For such situation, mixed usage must not be allowed.
 I feel that if pkgsrc one is preferred for B, A from pkgsrc also be used.
 
 -- 
 OBATA Akio / obache%NetBSD.org@localhost