pkg/45729: Build fix and minor improvements for security/p0f

[Pierre Pronchery <khorben%defora.org@localhost>]

>Number:         45729
>Category:       pkg
>Synopsis:       security/p0f does not build on NetBSD
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Dec 21 13:10:00 +0000 2011
>Originator:     Pierre Pronchery
>Release:        NetBSD 5.1_STABLE, pkgsrc-2011Q3, pkgsrc HEAD
>Organization:
>Environment:
System: NetBSD kwarx.defora.lan 5.1_STABLE NetBSD 5.1_STABLE (GENERIC) #3: Tue 
Sep 27 18:50:09 CEST 2011 
khorben%kwarx.defora.lan@localhost:/home/amd64/obj/sys/arch/amd64/compile/GENERIC
 amd64
Architecture: x86_64
Machine: amd64
>Description:
The patch-aa patch for security/p0f adds a dependency on the ".WAIT"
rule to the build, which breaks on my system (NetBSD/amd64 5.1 with
pkgsrc-2011Q3). Removing this dependency fixes the build for me.

Then, the patch-aa patch for security/p0f uses gmake explicitly; I have
therefore added it to the list of tools required.

Finally, the file doc/COPYING within p0f 2.0.8 contains the text for the
GNU LGPL version 2.1 license, which I have also added to the Makefile.
>How-To-Repeat:
Build security/p0f from pkgsrc:

$ cd /usr/pkgsrc/security/p0f
$ make build
[...]
gmake[1]: *** No rule to make target `.WAIT', needed by `all'.  Stop.
gmake[1]: Leaving directory `/home/netbsd/pkgsrc/work/security/p0f/work/p0f'
gmake: *** [all] Error 2
*** Error code 2

Stop.
make: stopped in /usr/pkgsrc/security/p0f
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/security/p0f
>Fix:
Apply this:

? .Makefile.swp
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/security/p0f/Makefile,v
retrieving revision 1.27
diff -p -u -r1.27 Makefile
--- Makefile    7 Jan 2011 04:16:14 -0000       1.27
+++ Makefile    21 Dec 2011 13:04:15 -0000
@@ -9,6 +9,7 @@ EXTRACT_SUFX=   .tgz
 MAINTAINER=    pkgsrc-users%NetBSD.org@localhost
 HOMEPAGE=      http://lcamtuf.coredump.cx/p0f.shtml
 COMMENT=       Passive OS fingerprinting tool
+LICENSE=       gnu-lgpl-v2.1
 
 PKG_DESTDIR_SUPPORT=   user-destdir
 
@@ -16,6 +17,8 @@ WRKSRC=               ${WRKDIR}/p0f
 
 PKG_SYSCONFSUBDIR=     p0f
 
+USE_TOOLS+=    gmake
+
 MAKE_ENV+=     LIBPCAP_PREFIX=${BUILDLINK_PREFIX.libpcap}
 
 CONF_FILES=    ${PREFIX}/share/examples/p0f/p0f.fp ${PKG_SYSCONFDIR}/p0f.fp
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/security/p0f/distinfo,v
retrieving revision 1.18
diff -p -u -r1.18 distinfo
--- distinfo    2 Oct 2011 05:04:03 -0000       1.18
+++ distinfo    21 Dec 2011 13:04:15 -0000
@@ -3,6 +3,6 @@ $NetBSD: distinfo,v 1.18 2011/10/02 05:0
 SHA1 (p0f-2.0.8.tgz) = 7b4d5b2f24af4b5a299979134bc7f6d7b1eaf875
 RMD160 (p0f-2.0.8.tgz) = 87d5b30d2d5e156b9fdcb026160155f413ce13d3
 Size (p0f-2.0.8.tgz) = 136877 bytes
-SHA1 (patch-aa) = 0e79fc52b7711a8cb31565f2da8a52761947853d
+SHA1 (patch-aa) = e64830b1000eeb7eb6240c64d1cab7e9de990f65
 SHA1 (patch-ad) = 378d9480c88d9a447684323c4a59f3c2f6f10d74
 SHA1 (patch-ae) = 581817151df41d320f7d36efa8a87e4f13c97adc
Index: patches/patch-aa
===================================================================
RCS file: /cvsroot/pkgsrc/security/p0f/patches/patch-aa,v
retrieving revision 1.10
diff -p -u -r1.10 patch-aa
--- patches/patch-aa    2 Oct 2011 05:04:03 -0000       1.10
+++ patches/patch-aa    21 Dec 2011 13:04:15 -0000
@@ -17,7 +17,7 @@ $NetBSD: patch-aa,v 1.10 2011/10/02 05:0
  TOOLS   = test/sendack test/sendack2 test/sendsyn
  
 -all: $(FILE) strip    
-+all: $(FILE) .WAIT strip
++all: $(FILE) strip
        @echo ">> You can also try 'make p0fq' to compile a sample query"
        @echo ">> client (see README for more information)."