Re: pkg/44577 openssl builtin detection, getting closer

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/44577; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/44577 openssl builtin detection, getting closer
Date: Mon, 14 Nov 2011 18:04:06 +0000

 On Mon, Nov 14, 2011 at 06:45:01AM +0000, John Marino wrote:
  >  The "included twice" theory is a pretty good one, but I still have the 
  >  questions:
  >  1) Why not use C header still defines to ignore re-included makefiles?
  >  2) What's the problem with redefining BUILTIN_PKG.openssl?  That implies 
  >  it's sacred, but the rest of the files can be redefined (albeit 
  >  erroneously) e.g. BUILTIN_VERSION.openssl.
  >  3) I'm not sure how your trick is going to help.  I'm able to detect the 
  >  case that it's redefined already.
 
 The question is why it's being included twice and why it's not getting
 the right answers the first time. The fact that it isn't means
 something's wrong; and if it *were* getting the right answers the
 first time it wouldn't need to reset/change the variable.
 
 (Plus, having the value change partway through evaluation of the
 makefiles is probably worse than having it be wrong.)
 
 All or almost all builtin.mk files are structured the same way, btw.
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost