Re: pkg/44577 openssl builtin detection, getting closer

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/44577; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/44577 openssl builtin detection, getting closer
Date: Mon, 14 Nov 2011 01:48:04 +0000

 On Mon, Nov 14, 2011 at 12:30:05AM +0000, John Marino wrote:
  >  I know which line of security/openssl/builtin.mk is causing openssl not 
  >  to be detected by the fake openssl.pc.
  >  
  >  .if !defined(BUILTIN_PKG.openssl) && \
  >       !empty(IS_BUILTIN.openssl:M[yY][eE][sS]) && \
  >       empty(H_OPENSSLV:M__nonexistent__)
  >  
  >  (line 32) is not evaluating to true because for some reason 
  >  BUILT_PKG.openssl is already defined in the two cases reported in this 
  >  PR.  If I comment out that clause to change the line to:
  >  
  >  if !empty(IS_BUILTIN.openssl:M[yY][eE][sS]) && \
  >       empty(H_OPENSSLV:M__nonexistent__)
  >  
  >  then the system openssl is detected as expected.
  >  
  >  I can't figure out where BUILT_PKG.openssl is previously defined.
  >  Is "!defined(BUILTIN_PKG.openssl)" really required?
  >  
  >  Answering these two questions will lead to the solution, I believe.
 
 My first guess would be that the builtin.mk file is being included
 twice for some reason.
 
 You can generally track this kind of problem down by inserting
 
    .if defined(IS_BUILTIN.openssl)
    .warning "foo 1"
    .endif
 
 blocks strategically.
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost