pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/45553: mozilla packages on NetBSD 4.0 should not use --with-system-libevent



The following reply was made to PR pkg/45553; it has been noted by GNATS.

From: Robert Elz <kre%munnari.OZ.AU@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/45553: mozilla packages on NetBSD 4.0 should not use 
--with-system-libevent
Date: Tue, 01 Nov 2011 15:26:58 +0700

     Date:        Tue,  1 Nov 2011 07:25:02 +0000 (UTC)
     From:        "OBATA Akio" <obache%NetBSD.org@localhost>
     Message-ID:  <20111101072502.B400A63BA70%www.NetBSD.org@localhost>
 
 Thanks...
 
   |  BUILDLINK_API_DEPENDS.libevent+= libevent>=?.?
 
 At least 1.1 I'm guessing.   I am testing it now.   I will append a
 patch to the PR if it works.
 
   |  I don't know mozilla packages require what version of libevent,
   |  but probably NetBSD-4 builtin version is too old for those packages.
 
 Yes, I just was not sure how to handle that properly.   I've added the
 BUILDLINK_API_DEPENDS.libevent+= line now, and am testing.   1.1 looks
 like it should split out NetBSD 4 from NetBSD 5 (NetBSD 4, according to
 the tests done in libevent/builtin.mk seems to be 1.0c or something like
 that).
 
 Incidentally, I see what appears to be a cu&pasto in devel/libevent/builtin.mk
 that someone can probably fix very easily ...
 
 # libevent>=1.0d: evbuffer_readline added
 _BLTN_EVENT_10d!=       \ 
         ${GREP} -c event_base_loopexit ${H_LIBEVENT} || ${TRUE}
 # libevent>=1.0c: event_set_log_callback, event_base_loopexit and
 #                 event_get_{version,method} added
 _BLTN_EVENT_10c!=       \
         ${GREP} -c event_base_loopexit ${H_LIBEVENT} || ${TRUE}
 
 
 As it exists now, _BLTN_EVENT_10d and _BLTN_EVENT_10c are set identically,
 which makes no sense, clearly the grep for _BLTN_EVENT_10d was supposed
 to be looking for evbuffer_readline rather than event_base_loopexit
 
 (and it is from this that I conclude that NetBSD 4.0 is 1.0c, as it has
 event_base_loopexit but does not have evbuffer_readline).
 
 kre
 


Home | Main Index | Thread Index | Old Index