Re: pkg/45491: pkgsrc does not bootstrap under OpenIndiana

[Alistair Crooks <agc%pkgsrc.org@localhost>]

On Wed, Oct 26, 2011 at 12:25:40AM +0300, Aleksey Cheusov wrote:
> > libarchive/archive_write_disk.c: In function 'set_fflags_platform':
> > libarchive/archive_write_disk.c:2265:18: error: expected expression before 
> > 'long'
> > libarchive/archive_write_disk.c:2267:19: error: expected expression before 
> > 'long'
> > libarchive/archive_write_disk.c:2273:18: error: expected expression before 
> > 'long'
> > libarchive/archive_write_disk.c:2277:19: error: expected expression before 
> > 'long'
> > *** Error code 1
> 
> On my system libarchive fails this way if
> pkg://sfe/system/file-system/e2fsprogs@1.41.14 package is installed.
> This package contains /usr/include/ext2fs/ext2fs.h file.
> libarcive finds it and tries to use EXT2_IOC_GETFLAGS ioctls.
> 
> The problem is that on OI-151 EXT2_IOC_GETFLAGS is defined as
> 
>    _IOR('f', 1, long)
> 
> where _IOR is defined in drm/drm.h which is not included.
> To me this looks like a bug in OpenIndiana.
> 
> I propose to commit the following workaround. Objections?
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/archivers/libarchive/Makefile,v
> retrieving revision 1.33
> diff -u -r1.33 Makefile
> --- Makefile  9 Jul 2010 12:03:55 -0000       1.33
> +++ Makefile  25 Oct 2011 21:22:30 -0000
> @@ -21,6 +21,13 @@
>  do-extract:
>       ${CP} -r ${FILESDIR} ${WRKSRC}
>  
> +.include "../../mk/bsd.prefs.mk"
> +
> +.if ${OPSYS} == SunOS
> +# workaround for pkg/45491
> +CONFIGURE_ENV+=      ac_cv_header_ext2fs_ext2_fs_h=no
> +.endif
> +
>  .include "../../archivers/bzip2/buildlink3.mk"
>  .include "../../devel/zlib/buildlink3.mk"
>  .include "../../mk/bsd.pkg.mk"

Yes, I think that's good as a stop-gap workaround, but let's keep the
bug open, and ask OpenIndiana to fix their sources upstream; we can
close the bug and delete the workaround as and when it's fixed
upstream.

Thanks,
Alistair