Re: pkg/45210: bootstrap fails with gcc-4.6 in libfetch (debian wheezy)

[Alistair Crooks <agc%pkgsrc.org@localhost>]

On Sat, Oct 01, 2011 at 08:21:14PM +0200, John Marino wrote:
> On 10/1/2011 8:15 PM, Alistair Crooks wrote:
> > 
> > if a variable isn't used, why bother to have it in the first place?
> > 
> > confused of cupertino
> 
> 
> In the case of the "low" variable, it's used based on the macro
> definition (e.g. IPV6_PORTRANGE), so you need to bother with it.

We only care if IPV6_PORTRANGE is defined, so we should declare
the variable:

#ifdef IPV6_PORTRANGE
        int     low;
#endif
 
> In the case of the "r" variable, it seems that this one can removed
> entirely.  I don't see its point of existence.

Heh, yeah, not needed.

Best,
Alistair