Re: pkg/45181 (the new patch uses mktemp with the -p option, which is not portable.)

[Tim Zingelman <tez%netbsd.org@localhost>]

The following reply was made to PR pkg/45181; it has been noted by GNATS.

From: Tim Zingelman <tez%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/45181 (the new patch uses mktemp with the -p option, which is
 not portable.)
Date: Wed, 27 Jul 2011 10:49:21 -0500

 Does this patch work for you?
 
 --- patches/patch-contrib_pdfmark_pdfroff.sh    19 Jul 2011 21:09:39
 -0000      1.1
 +++ patches/patch-contrib_pdfmark_pdfroff.sh    27 Jul 2011 15:41:14 -0000
 @@ -6,6 +6,7 @@
   
http://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/groff/groff-1.20.1-owl-tmp.diff?rev=1.2
  Modified for pkgsrc and excluded a documentaion change to doc/groff.texinfo
  that changes a `makeinfo' is too old warning into a fatal error.
 +Modified to not use '-p' option to mktemp which is missing on some platforms.
 
  Added patch to make pdfroff.sh use -dSAFER
  See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=538338 for why.
 @@ -18,7 +19,7 @@
   #
  -  WRKFILE=${GROFF_TMPDIR=${TMPDIR-${TMP-${TEMP-"."}}}}/pdf$$.tmp
  +  MYTMPDIR=${GROFF_TMPDIR-${TMPDIR-${TMP-${TEMP-"/tmp"}}}}
 -+  WRKDIR="`unset TMPDIR && mktemp -dp "$MYTMPDIR"
 groff-pdfroff.XXXXXXXXXX`" || exit
 ++  WRKDIR="`TMPDIR=$MYTMPDIR mktemp -d -t groff-pdfroff.XXXXXXXXXX`" || exit
  +
  +  trap 'rm -rf -- "$WRKDIR"' EXIT
  +  trap 'trap - EXIT; rm -rf -- "$WRKDIR"; exit 1' HUP INT QUIT PIPE TERM
 
  - Tim