Re: pkg/45136 ([MAINTAINER][PATCH] www/aws, fix DESTDIR breakage and other problems)

[John Marino <netbsd%marino.st@localhost>]

On 7/24/2011 3:10 PM, OBATA Akio wrote:
> The following reply was made to PR pkg/45136; it has been noted by GNATS.
>
> From: "OBATA Akio"<obache%netbsd.org@localhost>
> To: gnats-bugs%netbsd.org@localhost
> Cc:
> Subject: Re: pkg/45136 ([MAINTAINER][PATCH] www/aws, fix DESTDIR breakage and
>   other problems)
> Date: Sun, 24 Jul 2011 22:07:28 +0900
>
>   On Sun, 24 Jul 2011 18:00:07 +0900, John Marino<netbsd%marino.st@localhost>  
> wrote:
>
>   >   According to pkgsrc.se, the PLIST file was not removed as requested in
>   >   the provided patch.
>   >   Remove the PLIST, and it should fine.
>
>   Why do you want to use dynamic GENERATE_PLIST?
>   If just pdf document will be created (or not) with certain PKG_OPTIONS,
>   you can use PLIST_VARS and conditional PLIST, same as doing with ipv6 option.
>
>   Additionally, you should use ${PYTHONBIN} instead of python${PYVERSUFFIX}.
>
>   --
>   OBATA Akio / obache%NetBSD.org@localhost
"Additionally, you should use ${PYTHONBIN} instead of python${PYVERSUFFIX}"
Okay, I'll look at that next time.  I didn't know this variable.

"Why do you want to use dynamic GENERATE_PLIST?"
The answer is WAY more complicated than a simple pdf option.  Believe me, I had good 
reason to remove the existing static list and replace it with the dynamic one.  The 
number of permutations of files with the entire set of options is large, and using a 
static list is prone to error.  Without going into a lot of detail, it would be best to 
accept that a dynamic PLIST is the way to go here, which will always be correct.  The 
existing PLIST isn't "correct" minus pdf either, it's going several existing 
problems with it.

Regards,
John