pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

pkg/45085: pkgtools/pkgin use MAKE_DIRS instead of @exec ${MKDIR}



>Number:         45085
>Category:       pkg
>Synopsis:       pkgtools/pkgin use MAKE_DIRS instead of @exec ${MKDIR}
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jun 20 13:45:00 +0000 2011
>Originator:     Thomas Cort
>Release:        N/A
>Organization:
Minix3
>Environment:
Minix 192.168.122.210 3.2.0 i686
>Description:
During release building on Minix, we need to be able to install pkgin with
DESTDIR. Currently, pkgin uses "@exec ${MKDIR} %D/etc/pkgin" in PLIST. The
%D gets expanded to pkgsrc_root (not destdir/pkgsrc_root) which causes
problems for us.

We originally tried patching pkg_install in problem report pkgsrc/45078.
Joerg Sonnenberger suggested changing the package to use MAKE_DIRS.

Here's the patch to make pkgin use MAKE_DIRS.
>How-To-Repeat:

>Fix:
diff --git a/pkgtools/pkgin/Makefile b/pkgtools/pkgin/Makefile
index 9a2a038..5e1b23f 100644
--- a/pkgtools/pkgin/Makefile
+++ b/pkgtools/pkgin/Makefile
@@ -16,6 +16,7 @@ EGDIR=                        
${PREFIX}/share/examples/${PKGBASE}
 CONF_FILES=            ${EGDIR}/repositories.conf.example              \
                        ${PKG_SYSCONFDIR}/${PKGBASE}/repositories.conf
 
+MAKE_DIRS+=            ${PKG_SYSCONFDIR}/${PKGBASE}
 OWN_DIRS+=             ${PKG_SYSCONFDIR}/${PKGBASE}
 INSTALLATION_DIRS+=    bin ${PKGMANDIR}/man1 ${EGDIR}
 
diff --git a/pkgtools/pkgin/PLIST b/pkgtools/pkgin/PLIST
index d7c158b..0c80468 100644
--- a/pkgtools/pkgin/PLIST
+++ b/pkgtools/pkgin/PLIST
@@ -2,4 +2,3 @@
 bin/pkgin
 man/man1/pkgin.1
 share/examples/pkgin/repositories.conf.example
-@exec ${MKDIR} %D/etc/pkgin



Home | Main Index | Thread Index | Old Index