pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/45078: pkgtools/pkg_install expand %D to destdir/pkgsrc_root

The following reply was made to PR pkg/45078; it has been noted by GNATS.

From: Joerg Sonnenberger <>
Subject: Re: pkg/45078: pkgtools/pkg_install expand %D to destdir/pkgsrc_root
Date: Fri, 17 Jun 2011 19:08:28 +0200

 On Fri, Jun 17, 2011 at 02:45:01PM +0000, wrote:
 > PLIST files can have commands to be executed using the @exec directive. 
 > Pkgin for instance uses "@exec ${MKDIR} %D/etc/pkgin". The %D is supposed
 > to be expanded to pkgsrc root. Earlier pkg_add would ignore the destdir
 > when expanding the %D. This changes pkg_add to expand %D to
 > destdir/pkgsrc_root.
 > This patch was moved from pkg/45047 so that the PR would
 > only deal with one problem.
 I don't think this actually helps. Most PLISTs that still use @exec are
 certainly not ready for DESTDIR and +INSTALL/+DEINSTALL already get it
 via environment. As such, the packages should be fixed to not use
 @exec/@unexec. The case of pkgin is clear abuse, since MAKE_DIRS exists
 for exactly this purpose. The above only works by chance since mkdir
 exists outside the chroot as well.

Home | Main Index | Thread Index | Old Index