pkg/44990: afpd startup script doesn't write a pid file to /var/run

[herrgard%gmail.com@localhost]

>Number:         44990
>Category:       pkg
>Synopsis:       afpd startup script doesn't write a pid file to /var/run
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon May 23 21:20:00 +0000 2011
>Originator:     Max Herrgard
>Release:        DragonFly development
>Organization:
dragonfly
>Environment:
DragonFly zoidberg.luxh.dyndns.info 2.11-DEVELOPMENT DragonFly 
v2.11.0.249.ged4d6-DEVELOPMENT #10: Mon May 23 20:59:23 CEST 2011     
root%zoidberg.luxh.dyndns.info@localhost:/usr/obj/usr/src/sys/X86_64_GENERIC  
x86_64
>Description:
afpd startup script doesn't write a pid file to /var/run. This makes rcstop 
afpd not working.
>How-To-Repeat:
rcstart afpd
rcstop afpd
>Fix:
--- /usr/pkg/share/examples/rc.d/afpd   2011-04-24 12:58:00.000000000 +0200
+++ /etc/rc.d/afpd      2011-05-23 23:00:21.243690000 +0200
@@ -14,9 +14,10 @@
 
 name="afpd"
 rcvar=$name
+pidfile="/var/run/${name}.pid"
 command="/usr/pkg/libexec/netatalk/afpd"
+command_args="-P ${pidfile}"
 etcdir="/usr/pkg/etc/netatalk"
-pidfile="/var/run/${name}.pid"
 required_files="$etcdir/afpd.conf $etcdir/AppleVolumes.default 
$etcdir/AppleVolumes.system"
 
 load_rc_config $name