pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

pkg/44981: multimedia/{mplayer-share,mplayer,gmplayer}: allow building with ccache enabled



>Number:         44981
>Category:       pkg
>Synopsis:       multimedia/{mplayer-share,mplayer,gmplayer}: allow building 
>with ccache enabled
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed May 18 07:15:00 +0000 2011
>Originator:     Matthias Rampke
>Release:        DragonFly 2.11
>Organization:
>Environment:
DragonFly tp.2pktfkt.net 2.11-DEVELOPMENT DragonFly 
v2.11.0.210.ga5b46-DEVELOPMENT #2: Wed May 18 01:33:28 CEST 2011     
matthias%tp.2pktfkt.net@localhost:/usr/obj/export/src/sys/GENERIC  i386
>Description:
Makefile.common for mplayer-share, mplayer and gmplayer currently has

ONLY_FOR_COMPILER= gcc

which excludes building with ccache enabled. This is rather harsh, I don't have 
any problem building mplayer with this line removed and ccache; on the other 
hand it blocks rolling system upgrades.

If it is really necessary to build mplayer only with gcc, this still shouldn't 
simply fail but rather enforce this and move on.
>How-To-Repeat:
add

PKGSRC_COMPILER= ccache gcc

in mk.conf and then try to bmake multimedia/mplayer.
>Fix:
remove

ONLY_FOR_COMPILER= gcc

from multimedia/mplayer-share/Makefile.commonh


diff --git a/multimedia/mplayer-share/Makefile.common 
b/multimedia/mplayer-share/Makefile.common
index c856751..8bfb094 100644
--- a/multimedia/mplayer-share/Makefile.common
+++ b/multimedia/mplayer-share/Makefile.common
@@ -46,8 +46,6 @@ CONFIGURE_ARGS+=      --prefix=${PREFIX:Q} \
                        --with-extralibdir="${LOCALBASE}/lib" \
                        --disable-dvdread-internal --disable-smb
 
-ONLY_FOR_COMPILER=     gcc
-
 # The configure script attempts to test-execute compiled programs in /tmp,
 # but that directory may be mounted as noexec; work this around by setting
 # TMPDIR to ${WRKDIR}



Home | Main Index | Thread Index | Old Index