pkg/44914: comms/asterisk18 DIST_SUBDIR botch (+FIX)

[kre%munnari.OZ.AU@localhost]

>Number:         44914
>Category:       pkg
>Synopsis:       comms/asterisk18 DIST_SUBDIR botch (+FIX)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Apr 28 01:55:00 +0000 2011
>Originator:     Robert Elz
>Release:        NetBSD 5.0   (pkgsrc current (HEAD) 2011-04-27)
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 5.1 NetBSD 5.1 (JADE-1.12-20101117) #5: Wed 
Nov 17 05:30:55 ICT 2010 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/5.1/kernels/i386/JADE i386
Architecture: i386
Machine: i386
>Description:
        When comms/asterisk18 was revbumbed from no rev to nb1, its DIST_SUBDIR
        was make PKGNAME instead of PKGNAME_NOREV so that the distfiles could
        be distinct between the two versions.   That was all fine.

        Then it was revbumped again, but no-one noticed that meant (the way
        things were defined) that the distinfo file would need updating as
        well, and everyone would needlessly be refetching distfiles.

        That means that as it is now, pkgsrc just complains that the distinfo
        file contains no checksums for the distfiles, and everything fails.

>How-To-Repeat:
        By inspection, or just "make checksum" in pkgsrc/comms/asterisk18

>Fix:
        Rather than updating the distinfo, which would mean a refetch of the
        distfiles, and then this same problem potentially occurring again
        the next time there's some need of a revbumo (which was potentially
        even an auto revbump caused by some dependency package being updated)
        I think it is better to just wire down the name of the DIST_SUBDIR.
        If a new set of distfiles are ever needed, this will be easy to fix.
        I'm not sure if there is a better way, but this works ...

Index: Makefile
===================================================================
RCS file: /cvsroot/NetBSD/pkgsrc/comms/asterisk18/Makefile,v
retrieving revision 1.7
diff -u -r1.7 Makefile
--- Makefile    22 Apr 2011 13:43:09 -0000      1.7
+++ Makefile    28 Apr 2011 01:41:22 -0000
@@ -6,7 +6,7 @@
 DISTNAME=      asterisk-1.8.2.3
 #XXX change back with next revision
 #DIST_SUBDIR=  ${PKGNAME_NOREV}
-DIST_SUBDIR=   ${PKGNAME}
+DIST_SUBDIR=   ${DISTNAME}nb1
 PKGREVISION=   2
 DISTFILES=     ${DEFAULT_DISTFILES}
 EXTRACT_ONLY=  ${DISTNAME}.tar.gz