Re: pkg/36656: amanda-client will fail to backup the requested filesystem

[Wolfgang Stukenbrock <Wolfgang.Stukenbrock%nagler-company.com@localhost>]

Hi,

yes this patch will fix the problem.
It corresponds to the version 2 in my original posting.

If this will be in future releases of pkgsrc, the PR can be closed.

thanks

W. Stukenbrock

Tim Zingelman wrote:

> The following reply was made to PR pkg/36656; it has been noted by GNATS.
>
> From: Tim Zingelman <tez%netbsd.org@localhost>
> To: gnats-bugs%netbsd.org@localhost, 
> 	Wolfgang Stukenbrock <Wolfgang.Stukenbrock%nagler-company.com@localhost>, solaris-pkg-people%netbsd.org@localhost, 
> 	gnats-admin%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost
> Cc: 
> Subject: Re: pkg/36656: amanda-client will fail to backup the requested filesystem
> Date: Tue, 29 Mar 2011 11:50:00 -0500
>
>  Does this patch solve the problem?
>  
>  cat patches/patch-client-src_getfsent.c
>  $NetBSD$
>  
>  --- client-src/getfsent.c.orig  2011-03-29 16:29:42.605775000 +0000
>  +++ client-src/getfsent.c
>  @@ -476,6 +476,7 @@ samefile(
>   {
>     int i;
>     for(i = 0; i < 3; ++i) {
>  +    if (stats[i].st_dev == (dev_t)-1) continue;
>       if (stats[i].st_dev == estat->st_dev &&
>          stats[i].st_ino == estat->st_ino)
>         return 1;
>  
>  or is there a case when we would want a match with st_dev=-1?
>