pkg/44703: sysutils/hal: PLIST issue on Linux again [patch]

[cheusov%tut.by@localhost]

>Number:         44703
>Category:       pkg
>Synopsis:       sysutils/hal: PLIST issue on Linux again
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 09 10:45:00 +0000 2011
>Originator:     Aleksey Cheusov
>Release:        Linux 2.6.18-194.32.1.el5xen
>Organization:
<organization of PR author (multiple lines)>
>Environment:
System: Linux centos.imb.invention.com 2.6.18-194.32.1.el5xen #1 SMP Wed Jan 5 
19:32:33 EST 2011 i686 i686 i386 GNU/Linux
Architecture: i686

>Description:
sysutils/hal fails to build because
   => Checking file-check results for hal-0.5.11nb27
   ERROR: ************************************************************
   ERROR: The following files are in /usr/pkg but not in the PLIST:
   ERROR:         
/tmp/obj-pkgsrc/sysutils/hal/work/.destdir/usr/pkg/etc/rc.d/init.d/haldaemon
   *** Error code 1

This problem was already fixed in the past.
See http://gnats.netbsd.org/43767

Since revision 1.49 of Makefile it reappeared.

>How-To-Repeat:
Try to build the package on RHEL-based distributions and possibly Fedora.
>Fix:
As far as I can see the only thing that depends on OS-TYPE
is if init.d script is installed. So, it's safe to disable this check.
Maybe markd@ can explain his decision to remove --without-os-type
from CONFIGURE_ARGS.

With the following patch package is built fine on CentOS Linux.

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/sysutils/hal/Makefile,v
retrieving revision 1.52
diff -u -r1.52 Makefile
--- Makefile    17 Feb 2011 12:11:57 -0000      1.52
+++ Makefile    9 Mar 2011 10:34:04 -0000
@@ -32,6 +32,7 @@
 CONFIGURE_ARGS+=       --localstatedir=${VARBASE}
 CONFIGURE_ARGS+=       --with-pci-ids=${PREFIX}/share/pciids
 CONFIGURE_ARGS+=       --with-usb-ids=${PREFIX}/share/usbids
+CONFIGURE_ARGS+=       --without-os-type
 
 .include "../../mk/bsd.prefs.mk"