pkg/44662: Out of date pkgsrc/audio/libsamplerate/distinfo file may cause build to fail

[bughunting%xs4all.nl@localhost]

>Number:         44662
>Category:       pkg
>Synopsis:       Out of date pkgsrc/audio/libsamplerate/distinfo file may cause 
>build to fail
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 02 00:40:00 +0000 2011
>Originator:     Bug Hunting
>Release:        
>Organization:
>Environment:
>Description:
The pkgsrc/audio/libsamplerate/distinfo (v1.7) file is out of date which, 
depending
on what site the distfile is actually fetched from, might cause its build 
process to
fail.

This error was introduced when the author repackaged the program (after
making only some very small changes to it), while keeping the filename intact.
>How-To-Repeat:
cd /usr/pkgsrc/audio/libsamplerate
make fetch-list | less

This will give the following sources for the distfile:

<http://www.mega-nerd.com/SRC/libsamplerate-0.1.7.tar.gz>
<ftp://ftp.fi.NetBSD.org/pub/NetBSD/packages/distfiles/libsamplerate-0.1.7.tar.gz>
<ftp://ftp.NetBSD.org/pub/NetBSD/packages/distfiles/libsamplerate-0.1.7.tar.gz>
<http://ftp.NetBSD.org/pub/NetBSD/packages/distfiles/libsamplerate-0.1.7.tar.gz>
<ftp://ftp.FreeBSD.org/pub/FreeBSD/distfiles/libsamplerate-0.1.7.tar.gz>

Of these 5, numbers 2, 3 and 4 match the distfile information in pkgsrc's
current audio/libsamplerate/distinfo file (v1.7); numbers 1 and 5 don't match
that file but _do_ match each other (i.e., are the same files).

Fetching numbers 2 (matching distfile information) and 5 (not matching distfile
information), unpacking them, and then executing "diff -r" on their respective
newly created directories, shows the following:

$ diff -r 2/libsamplerate-0.1.7 5/libsamplerate-0.1.7
diff -r 2/libsamplerate-0.1.7/ChangeLog 5/libsamplerate-0.1.7/ChangeLog
14c14
<     Thanks to David Cournapeau for the bug report.
---
>     Thanks to David Cournapeau and Lev Givon for the bug report.
diff -r 2/libsamplerate-0.1.7/Win32/config.h 
5/libsamplerate-0.1.7/Win32/config.h
193,194c193
< <<<<<<< diff from left file
< #define VERSION "0.1.4"
---
> #define VERSION "0.1.7"
206,208d204
< ========
< #define VERSION "0.1.7"
< >>>>>>> diff from right file

The package's ChangeLog file, also viewable on the Web on
<http://www.mega-nerd.com/SRC/ChangeLog>, mentions
<http://www.mega-nerd.com/erikd/Blog/2009/Feb/14/index.html>.  In there,
the reason for the change above is stated:

``Update : 2009-02-15 11:19
David Cournapeau informs me that Lev Givon, as a user of David's
libsamplerate Python bindings, reported this bug to him and that it was actually
Lev that found the bug.''

So, after the initial release of libsamplerate-0.1.7.tar.gz, the author made
some changes, and then repackaged the program while keeping the exact
same name.
>Fix:
Apply the following patch:

$ cd /usr/pkgsrc/audio/libsamplerate/; cvs diff -u distinfo  
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/audio/libsamplerate/distinfo,v
retrieving revision 1.7
diff -u -r1.7 distinfo
--- distinfo    25 Feb 2009 19:35:46 -0000      1.7
+++ distinfo    2 Mar 2011 00:17:53 -0000
@@ -1,5 +1,5 @@
 $NetBSD: distinfo,v 1.7 2009/02/25 19:35:46 drochner Exp $
 
-SHA1 (libsamplerate-0.1.7.tar.gz) = 98a52392eb97f9ba724ca024b3af29a8a0cc0206
-RMD160 (libsamplerate-0.1.7.tar.gz) = 697a355393d21ad66ea4313b928f2c3322f67a39
-Size (libsamplerate-0.1.7.tar.gz) = 4340634 bytes
+SHA1 (libsamplerate-0.1.7.tar.gz) = f3f803ec5feae5a3fdb0fa3937277669e854386e
+RMD160 (libsamplerate-0.1.7.tar.gz) = a00f12571098fd6c50a8b9f8867cdcc3f36c1f60
+Size (libsamplerate-0.1.7.tar.gz) = 4340619 bytes

Note: I haven't checked the PGP signature
<http://www.mega-nerd.com/SRC/libsamplerate-0.1.7.tar.gz.asc>
on the new file; also, note that the signature might or might not have been
updated after the repackaging process anyway.