pkg/44609: multimedia/xvidcore fails to link on Solaris

[schaecsn%gmx.net@localhost]

>Number:         44609
>Category:       pkg
>Synopsis:       multimedia/xvidcore fails to link on Solaris
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Feb 20 04:00:00 +0000 2011
>Originator:     Stefan
>Release:        Sparc/Solaris 9
>Organization:
>Environment:
>Description:
multimedia/xvidcore 2010Q4

building fails in the linking phase:

  L: libxvidcore.so.4.2
ld: warning: option -o appears more than once, first setting taken
/usr/ccs/bin/ld: illegal option -- -
/usr/ccs/bin/ld: illegal option -- v


I think ld complains about this option:
--version-script=libxvidcore.ld 

>How-To-Repeat:

>Fix:
From the Makefile

.if !empty(PKGSRC_COMPILER:Msunpro)
CFLAGS+=                -D__inline=inline
SUBST_CLASSES+=         ld
SUBST_MESSAGE.ld=       Fixing linker arguments for Solaris
SUBST_STAGE.ld=         pre-configure
SUBST_FILES.ld=         configure
SUBST_SED.ld=           -e 
"s|-Wl,-soname,libxvidcore...(SHARED_EXTENSION)...(API_MAJOR)||"
SUBST_SED.ld+=          -e "s|-Wl,--version-script=libxvidcore.ld||"
.endif


I use gcc with sun's linker and assembler (I assume most gcc users on Solaris 
use sun's linker and assembler). Using the above definitions(without the 
CFLAGS) made it build successfully.

I left out the CFLAGS definition as this has nothing to do with my linker issue.