pkg/44469: djbdns package ipv6 patch uses deprecated ip6.int rather than ip6.arpa

[james_r-netbsdpr%jump.org.uk@localhost]

>Number:         44469
>Category:       pkg
>Synopsis:       djbdns package ipv6 patch uses deprecated ip6.int rather than 
>ip6.arpa
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed Jan 26 15:50:00 +0000 2011
>Originator:     James A. T. Rice
>Release:        
>Organization:
>Environment:
>Description:
The djbdns package uses the following ipv6 patch:
http://ftp.netbsd.org/pub/NetBSD/packages/distfiles/djbdns-1.05-ipv6.diff.bz2

which appears to be the authors first version of said patch, at:
http://www.fefe.de/dns/djbdns-1.05-ipv6.diff.bz2

the latest version, as of 2011-01-26 is from 2005-09-08, at:
http://www.fefe.de/dns/djbdns-1.05-test23.diff.bz2

This incorporates changes such as IPv6 reverse DNS being in
ip6.arpa rather than ip6.int (which was deprecated in 2006).



Another change incorporated is between
http://www.fefe.de/dns/djbdns-1.05-test7.diff.bz2
http://www.fefe.de/dns/djbdns-1.05-test8.diff.bz2

which had the following changes:

djbdns-1.05/dns.h
< +#define DNS_NAME6_DOMAIN (4*16+15)
---
> +#define DNS_NAME6_DOMAIN (4*16+10)

djbdns-1.05/dns_nd6.c
< +  byte_copy(name + 4*16,14,"\3ip6\3int\0");
< +  return 4*16+14;
---
> +  byte_copy(name + 4*16,9,"\3ip6\3int\0");
> +  return 4*16+9;

which seems to fix reading past the end of the constant string,
I have no idea if this also has security implications.


>How-To-Repeat:

>Fix:
Consider incorporating changes which are present in
http://www.fefe.de/dns/djbdns-1.05-test23.diff.bz2

Thanks
James